Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zero-Dim] fix reduce all and not keep dims case #53000

Closed

Conversation

YangQun1
Copy link
Contributor

PR types

PR changes

Describe

Depend on #52739, to fix the reduce all case.
With #52739 changes, the output dims of reduce sum op changed from {1} to {} for reduce_all=true and keep_dims=false case.

@paddle-bot
Copy link

paddle-bot bot commented Apr 17, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Apr 17, 2023
@paddle-bot
Copy link

paddle-bot bot commented Apr 17, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@YangQun1 YangQun1 added the Intel label Apr 17, 2023
@YangQun1 YangQun1 marked this pull request as draft April 17, 2023 12:34
@YangQun1
Copy link
Contributor Author

cc @zhouwei25 Could you help to pick the commit to your branch and try this fix?

@zhwesky2010
Copy link
Contributor

zhwesky2010 commented Apr 18, 2023

cc @zhouwei25 Could you help to pick the commit to your branch and try this fix?

thx, I think the fix is in paddle/phi/kernels/onednn/reduce_kernel_impl.h , I'll test it or you can just merge this fix.

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Apr 29, 2023

Sorry to inform you that d89c41e's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@YangQun1
Copy link
Contributor Author

Close this PR since the fix has been included in develop branch (https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/phi/kernels/onednn/reduce_kernel_impl.h#L105-L108)

@paddle-bot
Copy link

paddle-bot bot commented May 16, 2023

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨原生算子开发规范,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers Intel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants