【Hackathon 4 No.17】Add cummax / cummin API to Paddle #53546

Patrick-Star125 · 2023-05-06T03:58:11Z

PR types

New features

PR changes

APIs

Description

Add cummax / cummin API to Paddle

Link

Rfc PR: PaddlePaddle/community#401

待完成

RFC文档修改：[rfc] modify cummax / cummin API design community#531
中文文档：docs: add cummax/cummin docs docs#5903

paddle-bot · 2023-05-06T03:58:15Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

paddle-ci-bot · 2023-05-17T03:20:22Z

Sorry to inform you that fe0e522's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

… cummax

Patrick-Star125 · 2023-05-30T04:02:35Z

PR-CI-Windows-OPENBLAS的CI错误没有明显信息，请问这大概是什么问题呢？

luotao1 · 2023-05-30T04:06:31Z

PR-CI-Windows-OPENBLAS的CI错误没有明显信息

… cummax

Patrick-Star125 · 2023-06-01T22:26:25Z

修改完毕，麻烦review一下，辛苦了！@luotao1

GGBond8488

LGTM

GGBond8488 · 2023-06-05T02:28:28Z

paddle/phi/api/yaml/backward.yaml

+
+- backward_op : cummin_grad
+  forward : cummin(Tensor x, int axis=-1, int dtype=3) -> Tensor(out), Tensor(indices)
+  args : (Tensor x, Tensor indices, Tensor out_grad, int axis, int dtype)


同上，kernel也一样

GGBond8488 · 2023-06-05T02:33:01Z

python/paddle/tensor/math.py

+            outputs={'out': out, 'indices': indices},
+            attrs={'axis': axis, 'dtype': dtype},
+        )
+        return out, indices


这里不要返回两个值，参考argmax/argmin，与他们的返回保持一致

argmax/argmin是单返回值的函数，我参考的主要是kthvalue、mode这些返回（out，indices）

意思是indices只在c++端内部使用，python端不用返回是吗？

需要返回两个值，这样也ok，我的描述有误

GGBond8488 · 2023-06-05T02:45:07Z

paddle/phi/api/yaml/backward.yaml

@@ -453,6 +453,26 @@
    func : cross_grad
    data_type : out_grad

+- backward_op : cummax_grad
+  forward : cummax(Tensor x, int axis=-1, int dtype=3) -> Tensor(out), Tensor(indices)
+  args : (Tensor x, Tensor indices, Tensor out_grad, int axis, int dtype)


这样是没问题的，这里的x可以优化掉吗，似乎只会用到输入的维度

删除后在test_check_grad处会报参数数量不匹配，但是我无法通过删除test_check_grad参数解决这个问题

请问删除x是必要的吗，这里x传引用似乎不会有内存额外占用问题

看起来是kernel没有同步改？功能上是不必要的，这里主要是能优化掉的话，反向计算的时就少一个对x的引用，可能就能释放掉x

GGBond8488 · 2023-06-05T02:54:51Z

paddle/phi/kernels/cpu/cum_maxmin_kernel.cc

+    int idx = 0;
+    for (const auto i : build_range(x_dim_size)) {
+      if (axis == -2) {
+        std::cout << "stop point 1" << std::endl;


需要打日志的话用VLOG

GGBond8488 · 2023-06-05T03:03:36Z

paddle/phi/kernels/cpu/cum_maxmin_kernel.cc

+  while (!finished) {
+    T1 max = *reinterpret_cast<const T1*>(x_data);
+    int idx = 0;
+    for (const auto i : build_range(x_dim_size)) {


这里build_range有必要吗？简单的for (i=0, i<x_dim_size, i++) 似乎也能也能实现相应的功能，也少了构建vector的开销

GGBond8488 · 2023-06-05T03:04:45Z

paddle/phi/kernels/cpu/cum_maxmin_kernel.cc

+      indices_data[i * indices_stride] = idx;
+    }
+    if (ndims == 1) break;
+    for (const auto dim_i : build_range(ndims)) {


GGBond8488 · 2023-06-05T03:04:54Z

paddle/phi/kernels/cpu/cum_maxmin_kernel.cc

+    if (ndims == 1) break;
+    for (const auto dim_i : build_range(ndims)) {
+      if (axis == -2) {
+        std::cout << "stop point 2" << std::endl;


GGBond8488 · 2023-06-05T03:23:22Z

test/legacy_test/test_cummax_op.py

+    return cummax, indices
+
+
+class TestCummaxOp(OpTest):


单测文件直接放在/test下面吧

coverage流水线显示代码几乎没有运行，我不确定这是不是把测试代码直接放到/test下面的问题，是不是还有其它配置需要调整

@tianshuo78520a 大佬帮忙看看

请 @tianshuo78520a @zhangbo9674 看下，API 单测都放到 test/legacy_test 目录下么？

@Patrick-Star125 经过讨论，先把单测放到 test/legacy_test 目录下，后续我们会进行统一调整

GGBond8488

LGTM

jeff41404 · 2023-06-09T11:35:32Z

python/paddle/tensor/math.py

+        name (str, optional): Name for the operation (optional, default is None). For more information, please refer to :ref:`api_guide_Name`.
+
+    Returns:
+        out (tuple), Return the result of cummin operation and the corresponding index results. The dtype of cummin result is same with input x.


multiple return values write in multiple lines, one per line

jeff41404 · 2023-06-09T11:36:36Z

python/paddle/tensor/math.py

+        name (str, optional): Name for the operation (optional, default is None). For more information, please refer to :ref:`api_guide_Name`.
+
+    Returns:
+        out (tuple), Return the result of cummax operation and the corresponding index results. The dtype of cummax result is same with input x.


multiple return values write in multiple lines, one per line

jeff41404

LGTM

sunzhongkai588 · 2023-06-12T07:13:17Z

python/paddle/tensor/math.py

+        out (Tensor), The result of cummax operation. The dtype of cummax result is same with input x.
+        indices (Tensor), The corresponding index results of cummax operation.


没有换行成功

Suggested change

out (Tensor), The result of cummax operation. The dtype of cummax result is same with input x.

indices (Tensor), The corresponding index results of cummax operation.

out (Tensor), The result of cummax operation. The dtype of cummax result is same with input x.

indices (Tensor), The corresponding index results of cummax operation.

sunzhongkai588 · 2023-06-12T07:13:34Z

python/paddle/tensor/math.py

+        out (Tensor), The result of cummin operation. The dtype of cummin result is same with input x.
+        indices (Tensor), The corresponding index results of cummin operation.


Suggested change

out (Tensor), The result of cummin operation. The dtype of cummin result is same with input x.

indices (Tensor), The corresponding index results of cummin operation.

out (Tensor), The result of cummin operation. The dtype of cummin result is same with input x.

indices (Tensor), The corresponding index results of cummin operation.

sunzhongkai588

LGTM for docs

Patrick-Star125 added 2 commits May 2, 2023 20:38

add API and op for cummax/min

c4f6a10

test pass stage 1

ff601cc

paddle-bot bot added the contributor External developers label May 6, 2023

Patrick-Star125 mentioned this pull request May 7, 2023

[rfc] modify cummax / cummin API design PaddlePaddle/community#531

Merged

format code

fe0e522

Patrick-Star125 mentioned this pull request May 8, 2023

【PaddlePaddle Hackathon 第四期】任务总览 #51281

Closed

luotao1 assigned luotao1, GGBond8488 and Ligoml May 8, 2023

luotao1 added the API label May 8, 2023

luotao1 added the PaddlePaddle Hackathon label May 17, 2023

Patrick-Star125 added 3 commits May 29, 2023 11:03

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

90c50d3

… cummax

fix bug

32cc8c5

refine test sample

8c75a58

Patrick-Star125 added 12 commits May 30, 2023 22:23

fix bug

77cd93e

fix bug

9c8fe91

fix bug

c9ca0df

fix bug

e5102e1

fix bug

cecfa73

format

343d5d9

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

d438ec9

… cummax

fix bug

f398100

fix bug

1919e10

fix bug

1b0f4e7

fix bug

24c27a3

fix bug

d17bf57

Patrick-Star125 added 8 commits June 1, 2023 10:38

fix bug

b3d1863

fix bug

d8aefa2

merge main

60f08f6

fix bug

1ea7738

format

1ee7d80

format

722912f

foremat

51042b7

format

ec992f1

luotao1 previously approved these changes Jun 5, 2023

View reviewed changes

GGBond8488 previously approved these changes Jun 5, 2023

View reviewed changes

GGBond8488 reviewed Jun 5, 2023

View reviewed changes

Patrick-Star125 added 2 commits June 5, 2023 23:49

adjust test file position

18ccdaf

adjust test file position

401a944

Patrick-Star125 dismissed stale reviews from GGBond8488 and luotao1 via 401a944 June 5, 2023 15:50

restore test place

406ba76

GGBond8488 approved these changes Jun 9, 2023

View reviewed changes

jeff41404 reviewed Jun 9, 2023

View reviewed changes

correct out description

4011a80

luotao1 assigned sunzhongkai588 Jun 12, 2023

jeff41404 previously approved these changes Jun 12, 2023

View reviewed changes

sunzhongkai588 reviewed Jun 12, 2023

View reviewed changes

format

f60a11d

Patrick-Star125 dismissed jeff41404’s stale review via f60a11d June 12, 2023 13:16

sunzhongkai588 approved these changes Jun 13, 2023

View reviewed changes

luotao1 merged commit 3a3fb1f into PaddlePaddle:develop Jun 13, 2023

Patrick-Star125 deleted the cummax branch June 18, 2023 07:36

		out (Tensor), The result of cummax operation. The dtype of cummax result is same with input x.
		indices (Tensor), The corresponding index results of cummax operation.

		out (Tensor), The result of cummin operation. The dtype of cummin result is same with input x.
		indices (Tensor), The corresponding index results of cummin operation.

【Hackathon 4 No.17】Add cummax / cummin API to Paddle #53546

【Hackathon 4 No.17】Add cummax / cummin API to Paddle #53546

Conversation

Patrick-Star125 commented May 6, 2023 • edited Loading

PR types

PR changes

Description

Link

paddle-bot bot commented May 6, 2023

paddle-ci-bot bot commented May 17, 2023

Patrick-Star125 commented May 30, 2023

luotao1 commented May 30, 2023

Patrick-Star125 commented Jun 1, 2023

GGBond8488 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Patrick-Star125 Jun 5, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Patrick-Star125 Jun 5, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GGBond8488 left a comment

Choose a reason for hiding this comment

jeff41404 Jun 9, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeff41404 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sunzhongkai588 left a comment

Choose a reason for hiding this comment

Patrick-Star125 commented May 6, 2023 •

edited

Loading

Patrick-Star125 Jun 5, 2023 •

edited

Loading

Patrick-Star125 Jun 5, 2023 •

edited

Loading

jeff41404 Jun 9, 2023 •

edited

Loading