[PIR] Unify dyn_cast interface with pir::cast #57463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhangbopd
changed the title
winter-wang
reviewed
Sep 18, 2023
| @@ -37,6 +37,14 @@ class InferMetaInterface : public pir::OpInterfaceBase<InferMetaInterface> { | |||
| }; | |||
|
|
|||
| /// Constructor | |||
| InferMetaInterface(std::nullptr_t) // NOLINT | |||
There was a problem hiding this comment.
这两个构造函数的增加感觉不是必要的，而且会给IR库的扩展着造成额外的负担。
There was a problem hiding this comment.
OK，这里是想把 interface 抽出来，做一个 interfaceBase 的，在没有做 interfaceBase 前先和 op 的保持一致
winter-wang
requested changes
Sep 18, 2023
… dyn_cast_interface
zhangbopd
force-pushed
the
dyn_cast_interface
branch
from
82bae84
to
afaac44
Compare
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
* PR comment * unify dyn_cast_interface * rm detail
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 16, 2023
* PR comment * unify dyn_cast_interface * rm detail
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* PR comment * unify dyn_cast_interface * rm detail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Other
Pcard-67164