【Hackathon 5th No.15】 为 Paddle 新增 Tensor.to() 以及 Layer.astype() API -part #58244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
@zhwesky2010 目前ci还剩3个没有过，codestyle是因为 |
错误是格式问题，不是没有doc的问题，请根据提示里的precommit命令修改下。
|
zhwesky2010
reviewed
Nov 3, 2023
| for dtype in valid_dtypes: | ||
| net = net.astype(dtype) | ||
| typex_str = str(net._dtype) | ||
| self.assertEqual((typex_str == "paddle." + dtype), True) |
There was a problem hiding this comment.
测一下 实际parameter参数的dtype吧，这个只测了layer.dtype
There was a problem hiding this comment.
新增了对layer param以及buffer的类型测试
zhwesky2010
previously approved these changes
Nov 6, 2023
| @@ -40,6 +45,10 @@ def test_layer_astype(self): | |||
| net = net.astype(dtype) | |||
| typex_str = str(net._dtype) | |||
| self.assertEqual((typex_str == "paddle." + dtype), True) | |||
| param_typex_str = str(net.parameters()[0].dtype) | |||
| self.assertEqual((param_typex_str == "paddle." + dtype), True) | |||
There was a problem hiding this comment.
这里直接使用 self.assertTrue(param_typex_str, 'paddle.' + dtype) 不更简洁吗，建议后面可以优化下写法
There was a problem hiding this comment.
已经优化写法，麻烦老师有空的时候再次审核一下
zhwesky2010
previously approved these changes
Nov 7, 2023
jeff41404
reviewed
Nov 7, 2023
python/paddle/nn/layer/layers.py
Outdated
Comment on lines
929
to
930
| If set str, it can be "bool", "float16", "float32", "float64", | ||
| "int8", "int16", "int32", "int64", "uint8", "complex64", "complex128". |
jeff41404
reviewed
Nov 7, 2023
python/paddle/nn/layer/layers.py
Outdated
Comment on lines
998
to
999
| "dtype value error, must be 'bfloat16', 'float16', 'float32', 'float64', 'int8', 'int16', 'int32', 'int64', 'uint8', 'uint16', 'complex64', 'complex128', 'bool', or paddle.dtype, numpy.dtype, but recieve " | ||
| + str(dtype) |
Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com>
sunzhongkai588
approved these changes
Nov 9, 2023
昨天已经修过了，目前codestyle的CI已经过了 |
luotao1
changed the title
|
@YibinLiu666 请提交对应的中文文档 |
|
hi, @YibinLiu666
|
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
…part (PaddlePaddle#58244) * support tensor.to and layer.astype * add UT and comments * update * update com * update dtype * fix example test * update example * add some ut to fix ci-coverage * fix codestyle * fix codestyle * update * add ut to test layer params' and buffers' type * update test * fix doc * Update python/paddle/base/dygraph/tensor_patch_methods.py Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com> * update doc --------- Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com>
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
…part (PaddlePaddle#58244) * support tensor.to and layer.astype * add UT and comments * update * update com * update dtype * fix example test * update example * add some ut to fix ci-coverage * fix codestyle * fix codestyle * update * add ut to test layer params' and buffers' type * update test * fix doc * Update python/paddle/base/dygraph/tensor_patch_methods.py Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com> * update doc --------- Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Description
RFC: PaddlePaddle/community#690