Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dynamic Shape] Remove ShapeBroadcastOp redundant codes #60609

Merged
merged 1 commit into from
Jan 9, 2024
Merged

[Dynamic Shape] Remove ShapeBroadcastOp redundant codes #60609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 0 additions & 44 deletions paddle/fluid/pir/dialect/operator/ir/manual_op.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2983,50 +2983,6 @@ void ShapeBroadcastOp::Build(pir::Builder &builder,

namespace {

void ShapeBroadcastOpInferMeta(const phi::MetaTensor &x,
const phi::MetaTensor &y,
phi::MetaTensor *out) {
PADDLE_ENFORCE_EQ(
x.dims().size(),
1,
phi::errors::PreconditionNotMet(
"The size %d of x.dims() must be equal to 1.", x.dims().size()));
PADDLE_ENFORCE_EQ(
y.dims().size(),
1,
phi::errors::PreconditionNotMet(
"The size %d of y.dims() must be equal to 1.", y.dims().size()));
out->set_dims({std::max<int64_t>(x.dims().at(0), y.dims().at(0))});
// dtype need promote when meet input dtype with more precision
paddle::experimental::DataTypeSet dtype_set{x.dtype()};
dtype_set = dtype_set | paddle::experimental::DataTypeSet(y.dtype());
DataType promote_result = PromoteTypes(dtype_set);
if (promote_result == DataType::UNDEFINED) {
promote_result = x.dtype();
}
out->set_dtype(promote_result);
out->set_layout(x.layout());
out->share_lod(x);
}

} // namespace

void ShapeBroadcastOp::InferMeta(phi::InferMetaContext *infer_meta) {
auto fn = PD_INFER_META(ShapeBroadcastOpInferMeta);
fn(infer_meta);
}

phi::DataType ShapeBroadcastOp::GetKernelTypeForVar(
const std::string &var_name,
const phi::DataType &tensor_dtype,
const phi::DataType &expected_kernel_dtype) {
VLOG(4) << "Get KernelType for Var of op: ShapeBroadcastOp";

return expected_kernel_dtype;
}

namespace {

symbol::DimExpr GetBroadcastDimExpr(const symbol::DimExpr &lhs,
const symbol::DimExpr &rhs) {
if (lhs.isa<std::int64_t>() && rhs.isa<std::int64_t>()) {
Expand Down
11 changes: 1 addition & 10 deletions paddle/fluid/pir/dialect/operator/ir/manual_op.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,9 +557,7 @@ class Increment_Op

class IR_API ShapeBroadcastOp
: public pir::Op<ShapeBroadcastOp,
paddle::dialect::InferSymbolicShapeInterface,
paddle::dialect::InferMetaInterface,
paddle::dialect::GetKernelTypeForVarInterface> {
paddle::dialect::InferSymbolicShapeInterface> {
public:
using Op::Op;
static const char *name() { return "pd_op.shape_broadcast"; }
Expand All @@ -576,13 +574,6 @@ class IR_API ShapeBroadcastOp
pir::Value y() { return operand_source(1); }
pir::OpResult out() { return result(0); }

static void InferMeta(phi::InferMetaContext *infer_meta);

static phi::DataType GetKernelTypeForVar(
const std::string &var_name,
const phi::DataType &tensor_dtype,
const phi::DataType &expected_kernel_dtype);

bool InferSymbolicShape(pir::ShapeConstraintIRAnalysis *shape_analysis);
};

Expand Down