Skip to content

support fa3 varlen bwd and modify fa3 varlen fwd api #73831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 30, 2025
Merged

support fa3 varlen bwd and modify fa3 varlen fwd api #73831

merged 11 commits into from
Jul 30, 2025

Conversation

@umiswing
Copy link
Member

@umiswing umiswing commented Jul 4, 2025 •
edited
Loading

PR Category

Performance Optimization

PR Types

Performance

Description

Pcard-70459
Support fa3 varlen backward, modify api of fa3 varlen forward

@paddle-bot
Copy link

paddle-bot bot commented Jul 4, 2025

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@umiswing
Copy link
Member Author

umiswing commented Jul 4, 2025

/re-run all-failed

@umiswing
Copy link
Member Author

umiswing commented Jul 4, 2025

/re-run dcu

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 5.26316% with 36 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@89ad47c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddle/phi/infermeta/ternary.cc 0.00% 18 Missing ⚠️
python/paddle/nn/functional/flash_attention.py 16.66% 10 Missing ⚠️
paddle/phi/infermeta/backward.cc 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             develop   #73831   +/-   ##
==========================================
  Coverage           ?    5.26%           
==========================================
  Files              ?        3           
  Lines              ?       38           
  Branches           ?        0           
==========================================
  Hits               ?        2           
  Misses             ?       36           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Jul 13, 2025

Sorry to inform you that b579e6c's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@umiswing
Copy link
Member Author

umiswing commented Jul 24, 2025

/re-run all-failed

1 similar comment
@umiswing
Copy link
Member Author

umiswing commented Jul 24, 2025

/re-run all-failed

@umiswing umiswing changed the title Fa3 varlen dev support fa3 varlen bwd and modify fa3 varlen fwd api Jul 24, 2025
@umiswing umiswing requested a review from carryyu July 24, 2025 10:21
GuoxiaWang
GuoxiaWang previously approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@GuoxiaWang GuoxiaWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

carryyu
carryyu previously approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@carryyu carryyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umiswing umiswing dismissed stale reviews from carryyu and GuoxiaWang via 363cf55 July 28, 2025 02:27
@umiswing
Copy link
Member Author

umiswing commented Jul 28, 2025

/re-run all-failed

1 similar comment
@umiswing
Copy link
Member Author

umiswing commented Jul 28, 2025

/re-run all-failed

qingqing01
qingqing01 approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add UT

@umiswing
Copy link
Member Author

umiswing commented Jul 28, 2025

/re-run all-failed

@umiswing
Copy link
Member Author

umiswing commented Jul 29, 2025

/re-run all-failed

4 similar comments
@umiswing
Copy link
Member Author

umiswing commented Jul 29, 2025

/re-run all-failed

@umiswing
Copy link
Member Author

umiswing commented Jul 29, 2025

/re-run all-failed

@umiswing
Copy link
Member Author

umiswing commented Jul 30, 2025

/re-run all-failed

@umiswing
Copy link
Member Author

umiswing commented Jul 30, 2025

/re-run all-failed

@GuoxiaWang GuoxiaWang merged commit 35cae23 into PaddlePaddle:develop Jul 30, 2025
150 of 177 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qingqing01 qingqing01 qingqing01 approved these changes

@zyfncg zyfncg zyfncg approved these changes

@GuoxiaWang GuoxiaWang GuoxiaWang left review comments

@carryyu carryyu carryyu left review comments

+1 more reviewer

@vivienfanghuagood vivienfanghuagood vivienfanghuagood approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-ci: coverage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@umiswing @codecov-commenter @qingqing01 @zyfncg @GuoxiaWang @carryyu @vivienfanghuagood @XieYunshen