[API compatibility] add tril and triu out parameter #74624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhwesky2010
reviewed
Aug 14, 2025
python/paddle/tensor/creation.py
Outdated
| diagonal: int = 0, | ||
| *, | ||
| out: paddle.Tensor | None = None, | ||
| name: str | None = None, |
Contributor
Author
There was a problem hiding this comment.
是把*out放在name后面吗
python/paddle/tensor/creation.py
Outdated
| def triu( | ||
| x: paddle.Tensor, diagonal: int = 0, name: str | None = None | ||
| x: paddle.Tensor, | ||
| diagonal: int = 0, |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #74624 +/- ##
===========================================
Coverage ? 100.00%
===========================================
Files ? 2
Lines ? 3
Branches ? 0
===========================================
Hits ? 3
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhwesky2010
reviewed
Aug 18, 2025
Contributor
Author
|
/re-run all-failed |
Contributor
Author
|
/re-run all-failed |
Contributor
Author
|
/re-run all-failed |
1 similar comment
Contributor
Author
|
/re-run all-failed |
zhwesky2010
previously approved these changes
Aug 20, 2025
Contributor
Author
|
/re-run all-failed |
DanielSun11
reviewed
Aug 21, 2025
Contributor
Author
|
/re-run all-failed |
Contributor
Author
|
/re-run all-failed |
1 similar comment
Contributor
Author
|
/re-run all-failed |
Contributor
Author
|
/re-run all-failed |
1 similar comment
Contributor
Author
|
/re-run all-failed |
SigureMo
approved these changes
Aug 22, 2025
zyfncg
approved these changes
Aug 22, 2025
Luckycheng222
pushed a commit
to Luckycheng222/Paddle
that referenced
this pull request
Aug 25, 2025
* add tril and triu out parameter * change the place of parameter name and out * tril and triu api sink into C++ * add import tril and triu * fix testcase * fix testcase * fix testcase * fix testcase * change position * add compatibility test for tril and triu * fix conflict * fix testcase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User ExperiencePR Types
New featuresDescription
add out parameter for tril and triu api