Skip to content

Add FlashMask V2 #74729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 27, 2025
Merged

Add FlashMask V2 #74729

merged 9 commits into from
Aug 27, 2025

Conversation

@umiswing
Copy link
Member

@umiswing umiswing commented Aug 19, 2025 •
edited
Loading

PR Category

Performance Optimization

PR Types

Performance

Description

Pcard-70459
Add FlashMask V2

@umiswing @starcrown001
add flashmask v2
e42470f 
Co-authored-by: starcrown001 <148410714+starcrown001@users.noreply.github.com>
@paddle-bot
Copy link

paddle-bot bot commented Aug 19, 2025

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

umiswing and others added 2 commits August 19, 2025 16:45
@umiswing @starcrown001
supprot seqlenq != seqlenk in flashmask
2570959 
Co-authored-by: starcrown001 <148410714+starcrown001@users.noreply.github.com>
@umiswing
refine
7095b4a
@umiswing
Copy link
Member Author

umiswing commented Aug 19, 2025

/re-run all-failed

1 similar comment
@umiswing
Copy link
Member Author

umiswing commented Aug 19, 2025

/re-run all-failed

SigureMo
SigureMo previously approved these changes Aug 19, 2025
View reviewed changes
risemeup1
risemeup1 previously approved these changes Aug 19, 2025
View reviewed changes
@umiswing
Copy link
Member Author

umiswing commented Aug 19, 2025

/re-run all-failed

XiaoguangHu01
XiaoguangHu01 previously approved these changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V2版本和V1版本，未来接口需要统一，做到硬件无关。

zyfncg
zyfncg previously approved these changes Aug 19, 2025
View reviewed changes
@umiswing umiswing dismissed stale reviews from zyfncg, XiaoguangHu01, risemeup1, and SigureMo via cfd9737 August 22, 2025 09:23
@umiswing
Copy link
Member Author

umiswing commented Aug 22, 2025

/re-run all-failed

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@d4abdcf). Learn more about missing BASE report.

Files with missing lines Patch % Lines
python/paddle/nn/functional/flash_attention.py 0.00% 32 Missing ⚠️
paddle/phi/backends/dynload/dynamic_loader.cc 0.00% 6 Missing ⚠️
paddle/phi/infermeta/ternary.cc 0.00% 5 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop   #74729   +/-   ##
==========================================
  Coverage           ?    0.00%           
==========================================
  Files              ?        3           
  Lines              ?       43           
  Branches           ?        0           
==========================================
  Hits               ?        0           
  Misses             ?       43           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@umiswing
Copy link
Member Author

umiswing commented Aug 24, 2025

/re-run all-failed

1 similar comment
@umiswing
Copy link
Member Author

umiswing commented Aug 25, 2025

/re-run all-failed

risemeup1
risemeup1 previously approved these changes Aug 25, 2025
View reviewed changes
SigureMo
SigureMo previously approved these changes Aug 25, 2025
View reviewed changes
zyfncg
zyfncg previously approved these changes Aug 25, 2025
View reviewed changes
@umiswing umiswing dismissed stale reviews from zyfncg and SigureMo via fcfa895 August 26, 2025 02:31
@umiswing
Copy link
Member Author

umiswing commented Aug 26, 2025

/re-run all-failed

@umiswing umiswing mentioned this pull request Aug 26, 2025
Merged
@umiswing
Copy link
Member Author

umiswing commented Aug 26, 2025

/re-run all-failed

@umiswing
Copy link
Member Author

umiswing commented Aug 26, 2025

/re-run all-failed

XiaoguangHu01
XiaoguangHu01 approved these changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umiswing
Copy link
Member Author

umiswing commented Aug 27, 2025

/re-run all-failed

@GuoxiaWang GuoxiaWang merged commit 07a34bc into PaddlePaddle:develop Aug 27, 2025
129 of 141 checks passed
@sneaxiy sneaxiy mentioned this pull request Aug 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zyfncg zyfncg zyfncg approved these changes

@SigureMo SigureMo SigureMo approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@risemeup1 risemeup1 risemeup1 approved these changes

Assignees

No one assigned

Labels

skip-ci: coverage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@umiswing @codecov-commenter @zyfncg @SigureMo @XiaoguangHu01 @risemeup1 @GuoxiaWang