Skip to content

[API compatibility] support inplace and input parameter for silu api #74788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 28, 2025
Merged

[API compatibility] support inplace and input parameter for silu api #74788

merged 13 commits into from
Aug 28, 2025

Conversation

@Starrysea996
Copy link
Contributor

@Starrysea996 Starrysea996 commented Aug 20, 2025 •
edited
Loading

PR Category

User Experience

PR Types

New features

Description

  1. support _C_ops.silu_ and inplace parameter for nn.functional.silu

  2. support inplace parameter for nn.Silu

  3. support input parameter for nn.functional.silu

@paddle-bot
Copy link

paddle-bot bot commented Aug 20, 2025

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhwesky2010
zhwesky2010 reviewed Aug 20, 2025
View reviewed changes
python/paddle/nn/layer/activation.py Outdated
def extra_repr(self) -> str:
name_str = f'name={self._name}' if self._name else ''
return name_str
name_str = f', name={self._name}' if self._name else ''
Copy link
Contributor

@zhwesky2010 zhwesky2010 Aug 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个inplace直接填到上面字符串里去吧

test/legacy_test/test_silu_op.py
y_ref = silu(x)

place = base.CPUPlace()
with dg.guard(place) as g:
Copy link
Contributor

@zhwesky2010 zhwesky2010 Aug 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PIR下也需要测试一下，这个分支有可能跑不过

@Starrysea996
Copy link
Contributor Author

Starrysea996 commented Aug 21, 2025

/re-run all-failed

@Starrysea996
Copy link
Contributor Author

Starrysea996 commented Aug 22, 2025

/re-run all-failed

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@bb68c90). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...rface/infer_symbolic_shape/same_operands_result.cc 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (88.88%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop   #74788   +/-   ##
==========================================
  Coverage           ?   88.88%           
==========================================
  Files              ?        3           
  Lines              ?        9           
  Branches           ?        0           
==========================================
  Hits               ?        8           
  Misses             ?        1           
  Partials           ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Starrysea996
Copy link
Contributor Author

Starrysea996 commented Aug 22, 2025

/re-run all-failed

@Starrysea996
Copy link
Contributor Author

Starrysea996 commented Aug 22, 2025

/re-run all-failed

zhwesky2010
zhwesky2010 approved these changes Aug 22, 2025
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 requested review from SigureMo and zyfncg August 22, 2025 12:44
zyfncg
zyfncg previously approved these changes Aug 22, 2025
View reviewed changes
@Starrysea996
Copy link
Contributor Author

Starrysea996 commented Aug 25, 2025

/re-run all-failed

SigureMo
SigureMo previously approved these changes Aug 25, 2025
View reviewed changes
@Starrysea996
Copy link
Contributor Author

Starrysea996 commented Aug 25, 2025

/re-run all-failed

2 similar comments
@Starrysea996
Copy link
Contributor Author

Starrysea996 commented Aug 25, 2025

/re-run all-failed

@Starrysea996
Copy link
Contributor Author

Starrysea996 commented Aug 25, 2025

/re-run all-failed

zhwesky2010
zhwesky2010 previously approved these changes Aug 25, 2025
View reviewed changes
@Starrysea996
Copy link
Contributor Author

Starrysea996 commented Aug 26, 2025

/re-run all-failed

@Starrysea996 Starrysea996 dismissed stale reviews from zhwesky2010, zyfncg, and SigureMo via c924834 August 26, 2025 09:43
zhwesky2010
zhwesky2010 previously approved these changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zyfncg
zyfncg previously approved these changes Aug 26, 2025
View reviewed changes
XiaoguangHu01
XiaoguangHu01 previously approved these changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Starrysea996
Copy link
Contributor Author

Starrysea996 commented Aug 27, 2025

/re-run all-failed

@Starrysea996 Starrysea996 mentioned this pull request Aug 27, 2025
Merged
SigureMo
SigureMo previously approved these changes Aug 27, 2025
View reviewed changes
@Starrysea996
Copy link
Contributor Author

Starrysea996 commented Aug 27, 2025

/re-run all-failed

zhwesky2010
zhwesky2010 reviewed Aug 27, 2025
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加下PIR的测试case吧

@Starrysea996
Copy link
Contributor Author

Starrysea996 commented Aug 28, 2025

/re-run all-failed

@Starrysea996
Copy link
Contributor Author

Starrysea996 commented Aug 28, 2025

/re-run all-failed

1 similar comment
@Starrysea996
Copy link
Contributor Author

Starrysea996 commented Aug 28, 2025

/re-run all-failed

@Starrysea996
Copy link
Contributor Author

Starrysea996 commented Aug 28, 2025

/re-run all-failed

@zhwesky2010 zhwesky2010 merged commit bb71251 into PaddlePaddle:develop Aug 28, 2025
219 of 235 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zyfncg zyfncg zyfncg approved these changes

@SigureMo SigureMo SigureMo approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

Assignees

No one assigned

Labels

API Compatibility skip-ci: coverage skip-ci: distribute skip-ci: npu

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Starrysea996 @codecov-commenter @zyfncg @SigureMo @XiaoguangHu01 @zhwesky2010 @tianshuo78520a @swgu98 @risemeup1