[AutoParallel] Adapt grad clip for moe layer #74916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #74916 +/- ##
==========================================
Coverage ? 0.00%
==========================================
Files ? 1
Lines ? 1
Branches ? 0
==========================================
Hits ? 0
Misses ? 1
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/re-run all-failed |
3 similar comments
Contributor
Author
|
/re-run all-failed |
Contributor
Author
|
/re-run all-failed |
Contributor
Author
|
/re-run all-failed |
liym27
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Auto Parallel
PR Types
Bug fixes
Description
背景：
ernie 模型在
pp2 + num_hidden_layers=4 + moe_layer_start_index=3情况下，stage 0上不包含 moe 层，所有 grad mesh 都是 [0,1,2,3] ，在 grad clip 中会调用allreduce求和所有梯度stage 1上包含 moe 层，grad 大部分是 [4,5,6,7]；存在 moe softmax 的 grad mesh 是 [current_rank]，这些在 grad clip 会被 reshard 成 [4,5,6,7]，但并不会调用allreduce求和所有梯度解决方法：
grad clip 中
flag_auto_hybrid_pp控制着是否进行 allreduce 通信该 PR 修复
stage 1情况下适配 moe ，设置flag_auto_hybrid_pp=True，stage0和stage1可以进行allreduce通信card-92763