[DLPack] Bump DLPack to v1.2 and implement C functions exchange API #75650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
changed the title
SigureMo
requested review from
DrRyanHuang,
gouzil and
zrr1999
as code owners
SigureMo
requested review from
ForFishes,
LiYuRio,
XiaoguangHu01,
Xreki,
phlrain,
qili93,
sneaxiy,
wanghuancoder,
zhiqiu and
zhwesky2010
as code owners
This reverts commit 2a9fc21.
SigureMo
force-pushed
the
dlpack/implement-c-functions-exchange-api
branch
from
bc1743e to
c1735e4
Compare
SigureMo
removed request for
ForFishes,
LiYuRio,
XiaoguangHu01,
Xreki,
phlrain,
qili93,
sneaxiy,
wanghuancoder,
zhiqiu and
zhwesky2010
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (30.76%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #75650 +/- ##
==========================================
Coverage ? 30.76%
==========================================
Files ? 2
Lines ? 13
Branches ? 0
==========================================
Hits ? 4
Misses ? 9
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zyfncg
previously approved these changes
Oct 14, 2025
DrRyanHuang
previously approved these changes
Oct 14, 2025
Comment on lines
+775
to
+777
| } catch (const std::exception &e) { | ||
| PyErr_SetString(PyExc_RuntimeError, e.what()); | ||
| return -1; |
Contributor
There was a problem hiding this comment.
这里只需要管 std::exception，不需要管其他的异常吗？类似这样的？
try {
// 代码
} catch (const std::exception& e) {
// 处理标准异常
} catch (...) {
// 处理所有其他异常
}
Member
Author
There was a problem hiding this comment.
协议模板，这里不应该动
SigureMo
changed the title
gouzil
approved these changes
Oct 15, 2025
SigureMo
changed the title
zyfncg
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
New features
Description
Implement C functions for speed dlpack exchange and stream handling and bump DLPack to v1.2. Refer to https://github.com/apache/tvm-ffi/blob/main/python/tvm_ffi/_optional_torch_c_dlpack.py and dmlc/dlpack#174
TODOs
__c_dlpack_*methods to__c_dlpack_exchange_api__after [RFC] Support DLPACK C Functions for Speed Exchange and Stream Handling dmlc/dlpack#174 merged__c_dlpack_*APIs__c_dlpack_exchange_api__implementation on Flashinfer (needs [DLPack] C Functions for DLPack Speed Exchange and Stream Handling apache/tvm-ffi#96)__c_dlpack_exchange_api__