Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue with perpetual diff in event rules #157

Merged
merged 4 commits into from
Oct 8, 2019
Merged

Fixing issue with perpetual diff in event rules #157

merged 4 commits into from
Oct 8, 2019

Conversation

stmcallister
Copy link
Contributor

This addresses Issue 155

Test output.

TF_ACC=1 go test -run "TestAccPagerDutyEventRule_Basic" ./pagerduty -v -timeout 120m
=== RUN   TestAccPagerDutyEventRule_Basic
--- PASS: TestAccPagerDutyEventRule_Basic (11.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	11.934s

@ghost ghost added the size/M label Oct 3, 2019
heimweh
heimweh approved these changes Oct 7, 2019
View reviewed changes
Copy link
Collaborator

@heimweh heimweh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @stmcallister! This LGTM 👍

@stmcallister stmcallister merged commit 5063b7d into PagerDuty:master Oct 8, 2019
@yob
Copy link

yob commented Oct 9, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heimweh heimweh heimweh approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stmcallister @yob @heimweh