Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds proper documentation for pagerduty_tag resource in tag_assignmen… #563

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

Coolomina
Copy link
Contributor

Addresses #562

@johncoleman83
Copy link
Contributor

Hi @imjaroiswebdev, I have reviewed this doc change, and looks good to me.

To provide some context, The PagerDuty terraform docs for pagerduty_tag_assignment recommend putting the type as a supported argument as @Coolomina mentions clearly in the linked issue; however the pagerduty_tag resource does not support type as an argument (see docs here). I also notice that none of the PagerDuty terraform resources (which is not the same as resources in the REST API that do support the type attribute as a specifier of the resource itself) support the type argument unless it is used to distinguish a variety of the resource rather than the resource itself.

With that said, I think these changes should be added. I suppose I should clarify are the docs at /website/docs the proper docs for PagerDuty resource that we publish here?

@imjaroiswebdev
Copy link
Contributor

@johncoleman83 You totally right on what you say and @Coolomina thank you so much for your contribution, this update will definitely help other users of the Provider 💪🏽 😎

@imjaroiswebdev imjaroiswebdev merged commit d22a698 into PagerDuty:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants