Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DF/019: Fix error with update and index in same action. #322

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

mgolosova
Copy link
Collaborator

Sub-PR from #292

Current script can produce an action JSON in form
{"update":{...}, "index":{"_parent":...}} which makes no sense. This occurs
when the input JSON contains "_update" set to true and "_parent" set to
anything. Probably missed instance of "index" that should have been changed
to "$act" when the latter was introduced.


This commit is moved to a separate PR for it affects the integration process management and we need it in master ASAP.

Current script can produce an action JSON in form
{"update":{...}, "index":{"_parent":...}} which makes no sense. This occurs
when the input JSON contains "_update" set to true and "_parent" set to
anything. Probably missed instance of "index" that should have been changed
to "$act" when the latter was introduced.
@mgolosova mgolosova self-assigned this Feb 17, 2020
@mgolosova mgolosova merged commit 618583b into master Feb 20, 2020
@mgolosova mgolosova deleted the 019-fix-routing branch February 20, 2020 10:43
witxka added a commit that referenced this pull request Feb 26, 2020
Apply PR #253, #322, #314, #319

Conflicts:
	Utils/Dataflow/run/data4es-consistency-check
@Evildoor Evildoor mentioned this pull request Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants