Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons for gPlanarity #3659

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sled45
Copy link

@sled45 sled45 commented Mar 5, 2024

These icons should work. The .desktop file for gPlanarity is hardcoded though, so I opened an issue in hardcode-fixer.

@SmartFinn
Copy link
Member

Thanks for the contribution.

The icons have some issues:

  1. The icons have poor pixel alignment. The edges of objects do not fit the pixel grid. See Pixel alignment.
  2. Outlines, shadows, and the color of the circle do not match Papirus style. See _TEMPLATE@NNxNN.SVG files as an example.
    1. Outlines and shadows should be 1px for 32-64px icons, and 0.5 px for 22-24px icons.
    2. The shadows should be below the objects.
    3. The lighter color of the base circle should be #e4e4e4.

@sled45
Copy link
Author

sled45 commented Mar 5, 2024

I made changes based off the guidelines and your comments. Hopefully it looks better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants