Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GQLExecutor memory leak #9262

Open
Dschoordsch opened this issue Dec 4, 2023 · 10 comments
Open

GQLExecutor memory leak #9262

Dschoordsch opened this issue Dec 4, 2023 · 10 comments
Labels
bug p3 Should be addressed when able stale

Comments

@Dschoordsch
Copy link
Contributor

The GQLExecutor memory consumption goes steadily up. As seen on here 🔒(top three lines)
Screenshot 2023-12-04 at 12 13 14
the memory usage stayed high even through the weekend where I would expect it to drop.

@Dschoordsch Dschoordsch added bug p3 Should be addressed when able labels Dec 4, 2023
@Dschoordsch
Copy link
Contributor Author

Labelling it P3 as it's not critical now. Could be related to #8414

@Dschoordsch
Copy link
Contributor Author

@rafaelromcar-parabol This could be an issue if we don't release for some time, like over christmas

@rafaelromcar-parabol
Copy link
Contributor

We should keep an eye on it, for sure. But keep in mind that if the containers arrive to 4 GB of memory, they will be automatically restarted.

That said, we could restart the application next week before Christmas if needed. During the week or on the weekend. It can be done easily using the last pipeline in the Gitlab repository.

@rafaelromcar-parabol
Copy link
Contributor

Also, I think this should be a P2. Mem leaks should always be fixed asap as they can affect stability. Even more in our application, that doesn't like restarting components very much. At least it didn't before this. Let's see after the release this week.

@mattkrick
Copy link
Member

Blocked behind #9282

@rafaelromcar-parabol
Copy link
Contributor

I was checking the memory usage on the GQL Ex and they are fine but at more than 60%. Which is fine, because if we do not release, the worst that can happen is having Kubernetes restarting them if they reach 100%. It isn't a big problem. Just sharing my thoughts here.

@mattkrick
Copy link
Member

true for the saas! for certain clients who do do not manage their infra as diligently as we do, restarts may pose a problem 😅

@rafaelromcar-parabol
Copy link
Contributor

Of course! I was talking about the Christmas period for the SaaS 😸 PPMIs haven't been updated in a long while. They are still in 6.83.0 and they have been like that for a while.

@jordanh
Copy link
Contributor

jordanh commented Mar 15, 2024

Prioritized to backlog

Copy link
Contributor

Stale issue

@github-actions github-actions bot added the stale label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug p3 Should be addressed when able stale
Projects
Status: No status
Status: Backlog
Status: No status
Development

No branches or pull requests

5 participants