Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add AuthIdentityMicrosoft #9612

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

Dschoordsch
Copy link
Contributor

The GraphQL type was not correctly added. This lead to server errors when opening "My Settings".

Testing scenarios

  • log in with Microsoft
  • open "My settings" from the top right menu
  • see no server errors

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

The GraphQL type was not correctly added. This lead to server errors
when openeing "My Settings".
@github-actions github-actions bot added the size/s label Apr 9, 2024
@Dschoordsch Dschoordsch merged commit e3d8b38 into master Apr 9, 2024
6 checks passed
@Dschoordsch Dschoordsch deleted the fix/addAuthIdentityMicrosoft branch April 9, 2024 12:18
@Dschoordsch
Copy link
Contributor Author

Sentry Issue: ACTION-PRODUCTION-GGM

@github-actions github-actions bot mentioned this pull request Apr 9, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant