You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This documents a number of variables which should be removed/altered into a system like traits on basetype objects
/datum
isprocessing - only checked in some rare cases, convert to a trait. TG also has GC destroyed as a trait, I wouldn't port something like that due to the innate pressure it puts on the GC (and potential byond weirdness)
var_edited- Convert to a trait
active_timers - Potentially does not need to exist, could use a signal system for example. Only currently used for the doppler_array
tgui_shared_states - Doesn't actually appear to be needed but may be a pain in the ass to remove, pretty much used just with the autolathe and cargo console
/atom
suit_fibers - handled pretty well but could be a bit better in some ways, diet lazy list
level - underutilized variable that basically just matters for pipes being under the floor, we got other ways to do this now
pass_flags_self - value never changed
germ_level - could be changed to just be a var on specific datums instead of ALL atoms
simulated - set on 3 datums, just removing it will probably be fine
bubble_icon - basically a mob var on atoms for some strange reason
dont_save - set to true on mobs and nothing else, convert to istype
container_type - this ain't ever gonna be something turfs or areas gotta worry about, should be on the movable level
admin_spawned - Trait based approach works for this
atom_colours - we have initial(), probably not needed
chat_color_name - we don't compare this value, unused
chat_color - questionable if it needs to exist, isn't called very often and is overridden by get_runechat_color in some cases, probably could be mob only at least
blood_color - mob var on atom, blood is also due for a refactor
/movable
move_speed - pretty much unused
l_move_time - used just for organs now, can be refactored out quite easily
no_spin - called rarely, trait em boys
no_spin_thrown - does not need to exist
moved_recently - unused except for the electropack, does not need to exist
face_while_pulling - probably doesn't need to exist, and if it does better as a trait
throwforce - random item var on the movable level
inertia_moving - unset in the same proc it's called in
create_point_bubble - random item var in movable
/mob
leap_icon - random alien hunter var on mobs
use_me - not needed, can just override the verb
damageoverlaytemp - why does this exist
attack_log_old - generally retired
currently_grab_pulled - grab moment
can_strip
name_archive - don't think this needs to exist anymore
flying - trait it
satiety - carbon var on mobs
research_scanner - trait it
mapobjs - unused
dna - carbon level on mob level
radiation - carbon level on mob level
move_on_shuttle - set on one place, istype it
has_enabled_antagHUD - ghost level var on mob
can_change_intents - could be a trait
proc_holder_list - basically unused
lastarea - uneeded
has_unlimited_silicon_privilege - trait it
control_object - does not need to exist
player_logged - should be a mind var tbh
player_ghosted - replace with a timer
listed_turf - this is some jank shit right here
shouldnt_see - we just never set this LMAO
last_logout - probably doesn't need to exist
chameleon_item_actions - could just be done without the related list
tkgrabbed_objects - could be handled better or at the least bumped up
/turfs
pathing_pass_method - unused
/area
report_alerts - not compared anywhere
no_air - unused
uid & global_uid - we still just use UIDs
is_haunted - trait it
/obj
species_exception - random item var on obj
sharp - random item var on obj
force - random item var on obj
custom_fire_overlay - just add behavior on a child call vs this
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
This documents a number of variables which should be removed/altered into a system like traits on basetype objects
/datum
/atom
can_leave_fibers
var to/obj/item/clothing
instead of being on/atom
#23005/movable
/mob
/turfs
/area
/obj
Beta Was this translation helpful? Give feedback.
All reactions