Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Buggy shortcuts when using Option key as modifier #11

Closed
ParthJadhav opened this issue Dec 27, 2022 · 0 comments · Fixed by #31
Closed

Address Buggy shortcuts when using Option key as modifier #11

ParthJadhav opened this issue Dec 27, 2022 · 0 comments · Fixed by #31
Labels
bug Something isn't working

Comments

@ParthJadhav
Copy link
Owner

hotkeys which have option key doesn't work as expected.
@ParthJadhav ParthJadhav added bug Something isn't working TODO labels Dec 27, 2022
@ParthJadhav ParthJadhav changed the title 🐛 Address Buggy shortcuts when using Option key as modifier Address Buggy shortcuts when using Option key as modifier Dec 27, 2022
@ParthJadhav ParthJadhav removed the TODO label Jan 2, 2023
Ty3uK added a commit to Ty3uK/Verve that referenced this issue Jan 5, 2023
@Ty3uK
fix: shortcuts with Option key
fbde516 
Related to ParthJadhav#11.

`event.key` returns transformed char when `option` key is pressed.

For example, when user is trying to record shortcut `Option+Shift+G`
`event.key` returns `Option+Shift+˝`.

`event.code` returns `KeyG` insted. So getting substring with offset 3
fixes this issue.

This commit fixes another bug: when user records shortcut that already
registered, window will hide. Adding `unregister` before start recording
fixes this issue.
Ty3uK added a commit to Ty3uK/Verve that referenced this issue Jan 5, 2023
@Ty3uK
fix: shortcuts with Option key
13d11e7 
Related to ParthJadhav#11.

`event.key` returns transformed char when `option` key is pressed.

For example, when user is trying to record shortcut `Option+Shift+G`,
`event.key` returns `Option+Shift+˝`.

`event.code` returns `KeyG` instead. So getting substring with offset 3
fixes this issue.

This commit fixes another bug: when user records shortcut that already
registered, window will hide. Adding `unregister` before start recording
fixes this issue.
@Ty3uK Ty3uK mentioned this issue Jan 5, 2023
Merged
@ParthJadhav ParthJadhav linked a pull request Jan 6, 2023 that will close this issue
fix: shortcuts with Option key #31
Merged
ParthJadhav pushed a commit that referenced this issue Jan 6, 2023
@Ty3uK
fix: shortcuts with Option key (#31)
8eb8ded 
* fix: shortcuts with `Option` key

Related to #11 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: shortcuts with Option key Ty3uK/Verve
1 participant
@ParthJadhav