Rename to ApiScopes

Author: jasontaylordev

src/ServiceControl.Audit/App.config

@@ -42,7 +42,7 @@ These settings are only here so that we can debug ServiceControl while developin
     <!-- <add key="ServiceControl/Authentication.ServicePulse.Enabled" value="false" />
     <add key="ServiceControl/Authentication.ServicePulse.ClientId" value="" />
     <add key="ServiceControl/Authentication.ServicePulse.Authority" value="" />
-    <add key="ServiceControl/Authentication.ServicePulse.ApiScope" value="" /> -->
+    <add key="ServiceControl/Authentication.ServicePulse.ApiScopes" value="" /> -->
   </appSettings>
   <connectionStrings>
     <!-- DEVS - Pick a transport connection string to match chosen transport above -->

src/ServiceControl.Infrastructure/OpenIdConnectSettings.cs

@@ -26,7 +26,7 @@ public OpenIdConnectSettings(SettingsRootNamespace rootNamespace, bool validateC
         ValidateIssuerSigningKey = SettingsReader.Read(rootNamespace, "Authentication.ValidateIssuerSigningKey", true);
         RequireHttpsMetadata = SettingsReader.Read(rootNamespace, "Authentication.RequireHttpsMetadata", true);
         ServicePulseClientId = SettingsReader.Read<string>(rootNamespace, "Authentication.ServicePulse.ClientId");
-        ServicePulseApiScope = SettingsReader.Read<string>(rootNamespace, "Authentication.ServicePulse.ApiScope");
+        ServicePulseApiScopes = SettingsReader.Read<string>(rootNamespace, "Authentication.ServicePulse.ApiScopes");
         ServicePulseAuthority = SettingsReader.Read<string>(rootNamespace, "Authentication.ServicePulse.Authority");
 
         if (validateConfiguration)
@@ -65,8 +65,8 @@ public OpenIdConnectSettings(SettingsRootNamespace rootNamespace, bool validateC
     [JsonPropertyName("servicePulseClientId")]
     public string ServicePulseClientId { get; }
 
-    [JsonPropertyName("servicePulseApiScope")]
-    public string ServicePulseApiScope { get; }
+    [JsonPropertyName("servicePulseApiScopes")]
+    public string ServicePulseApiScopes { get; }
 
     void Validate()
     {
@@ -128,9 +128,9 @@ void Validate()
             throw new Exception("Authentication.ServicePulse.ClientId is required when Authentication.ServicePulse.Enabled is true.");
         }
 
-        if (string.IsNullOrWhiteSpace(ServicePulseApiScope))
+        if (string.IsNullOrWhiteSpace(ServicePulseApiScopes))
         {
-            throw new Exception("Authentication.ServicePulse.ApiScope is required when Authentication.ServicePulse.Enabled is true.");
+            throw new Exception("Authentication.ServicePulse.ApiScopes is required when Authentication.ServicePulse.Enabled is true.");
         }
 
         if (ServicePulseAuthority != null && !Uri.TryCreate(ServicePulseAuthority, UriKind.Absolute, out _))
@@ -148,6 +148,6 @@ void Validate()
         logger.LogInformation("  RequireHttpsMetadata: {RequireHttpsMetadata}", RequireHttpsMetadata);
         logger.LogInformation("  ServicePulseClientId: {ServicePulseClientId}", ServicePulseClientId);
         logger.LogInformation("  ServicePulseAuthority: {ServicePulseAuthority}", ServicePulseAuthority);
-        logger.LogInformation("  ServicePulseApiScope: {ServicePulseApiScope}", ServicePulseApiScope);
+        logger.LogInformation("  ServicePulseApiScopes: {ServicePulseApiScopes}", ServicePulseApiScopes);
     }
 }

src/ServiceControl.Monitoring/App.config

@@ -39,7 +39,7 @@ These settings are only here so that we can debug ServiceControl while developin
     <!-- <add key="ServiceControl/Authentication.ServicePulse.Enabled" value="false" />
     <add key="ServiceControl/Authentication.ServicePulse.ClientId" value="" />
     <add key="ServiceControl/Authentication.ServicePulse.Authority" value="" />
-    <add key="ServiceControl/Authentication.ServicePulse.ApiScope" value="" /> -->
+    <add key="ServiceControl/Authentication.ServicePulse.ApiScopes" value="" /> -->
   </appSettings>
   <connectionStrings>
     <!-- DEVS - Pick a transport connection string to match chosen transport above -->

src/ServiceControl.UnitTests/ApprovalFiles/APIApprovals.PlatformSampleSettings.approved.txt

@@ -51,7 +51,7 @@
     "requireHttpsMetadata": false,
     "servicePulseAuthority": null,
     "servicePulseClientId": null,
-    "servicePulseApiScope": null
+    "servicePulseApiScopes": null
   },
   "ShutdownTimeout": "00:00:05"
 }