Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout messages should have a dedicated icon #221

Closed
dannycohen opened this issue Jan 26, 2014 · 14 comments
Closed

Timeout messages should have a dedicated icon #221

dannycohen opened this issue Jan 26, 2014 · 14 comments
Labels
Milestone

Comments

@dannycohen
Copy link

  1. Timeout messages (like "BuyersRemorseIsOver" in VideoStore) currently have a standard "Command" icons (see image below)
  2. It would be more accurate to provide them with a "timer" icon
  3. Tooltip should be changed to:
    • When hovering above message icon: "Saga Timeout Message"
    • When hovering above the connecting line from the message sending the Timeout message to the timeout message: "Requested Saga Timeout"
  4. Note this applies to all timeout message, also in Saga View (identified by the "IsSagaTimeoutMessage" = True)

image

// CC @sergioc , @HEskandari, @udidahan

@ghost ghost assigned joj Jan 26, 2014
@dannycohen
Copy link
Author

@sergioc - can you propose an appropriate icon for the above ?

@sergioc
Copy link

sergioc commented Jan 26, 2014

Can Timeout messages be commands or events, or they're on a class of its own?

@dannycohen
Copy link
Author

@sergioc - Consider them as a class of their own (i.e. the highlighted icon below should be changed)

image

@sergioc
Copy link

sergioc commented Jan 26, 2014

How about the distinction for connector lines?

@dannycohen
Copy link
Author

@sergioc - Good point. Makes sense to have such a distinction. Proposals ?

@sergioc
Copy link

sergioc commented Jan 26, 2014

Need to think about. Are there other types of messages to consider besides these 3?

@dannycohen
Copy link
Author

@sergioc - possibly one additional type called "In-memory messages"
(See http://docs.particular.net/NServiceBus/using-the-in-memory-bus)

Not sure whether we can currently identify them but its certainly something worth investigating.

@andreasohlund - is there any indicator in SC we can use to identify in-memory messages ?

@udidahan - Can you specify an in-memory commands or just events ?

@udidahan
Copy link
Member

Don’t worry about the in-memory stuff for now. We’re not yet even sure if they should stay.

@andreasohlund
Copy link
Member

At this stage we are not auditing inmemory messages so there is no easy way to visualize them.

We need to talk more about inmemory messages since there is alot of different ideas on how they should work

Sent from my iPhone

On 26 jan 2014, at 15:58, Danny Cohen notifications@github.com wrote:

@sergioc - possibly one additional type called "In-memory messages"
(See http://docs.particular.net/NServiceBus/using-the-in-memory-bus)

Not sure whether we can currently identify them but its certainly something worth investigating.

@andreasohlund - is there any indicator in SC we can use to identify in-memory messages ?

@udidahan - Can you specify an in-memory commands or just events ?


Reply to this email directly or view it on GitHub.

@sergioc
Copy link

sergioc commented Feb 4, 2014

@udidahan
Copy link
Member

udidahan commented Feb 4, 2014

The icon is fine, but then the little clock icon beside the saga name is a bit redundant, isn't it?

I'm also still not convinced about having the timeouts appear in the message flow diagram. If a saga requests a timeout, I'd lean to not having it in the flow. On the other hand, if some other object calls Bus.Defer(new SomeTimeout()) then I'm pretty comfortable with having that appear in the flow.

@sergioc
Copy link

sergioc commented Feb 4, 2014

Yes, little timeout icon is now redundant and could be removed.

@dannycohen
Copy link
Author

@udidahan - Lets sync on the timeout representation on all views.

@joj
Copy link
Contributor

joj commented Feb 4, 2014

This is how it looks right now:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants