-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout messages should have a dedicated icon #221
Comments
@sergioc - can you propose an appropriate icon for the above ? |
Can Timeout messages be commands or events, or they're on a class of its own? |
@sergioc - Consider them as a class of their own (i.e. the highlighted icon below should be changed) |
How about the distinction for connector lines? |
@sergioc - Good point. Makes sense to have such a distinction. Proposals ? |
Need to think about. Are there other types of messages to consider besides these 3? |
@sergioc - possibly one additional type called "In-memory messages" Not sure whether we can currently identify them but its certainly something worth investigating. @andreasohlund - is there any indicator in SC we can use to identify in-memory messages ? @udidahan - Can you specify an in-memory commands or just events ? |
Don’t worry about the in-memory stuff for now. We’re not yet even sure if they should stay. |
At this stage we are not auditing inmemory messages so there is no easy way to visualize them. We need to talk more about inmemory messages since there is alot of different ideas on how they should work Sent from my iPhone
|
Icon proposal: @udidahan @andreasohlund @dannycohen please comment |
The icon is fine, but then the little clock icon beside the saga name is a bit redundant, isn't it? I'm also still not convinced about having the timeouts appear in the message flow diagram. If a saga requests a timeout, I'd lean to not having it in the flow. On the other hand, if some other object calls |
Yes, little timeout icon is now redundant and could be removed. |
@udidahan - Lets sync on the timeout representation on all views. |
// CC @sergioc , @HEskandari, @udidahan
The text was updated successfully, but these errors were encountered: