Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json parser crashes with invalid characters #404

Closed
distantcam opened this issue Oct 17, 2014 · 0 comments
Closed

Json parser crashes with invalid characters #404

distantcam opened this issue Oct 17, 2014 · 0 comments
Labels
Milestone

Comments

@distantcam
Copy link
Contributor

Instead, we should ignore the error, log it, and dump the rest of the message as raw text for display.

From raygun:

[JsonReaderException: Unexpected character encountered while parsing value: <. Path '', line 0, position 0.]
Newtonsoft.Json.JsonTextReader.ParseValue():0
Newtonsoft.Json.JsonTextReader.ReadInternal():67
Newtonsoft.Json.JsonTextReader.Read():7
Particular.ServiceInsight.Desktop.CodeParser.JsonParser.Parse(SourcePart text) in c:\BuildAgent\work\2be762a799648224\src\ServiceInsight.Desktop\CodeParser\JsonParser.cs:25
Particular.ServiceInsight.Desktop.CodeParser.BaseParser.Parse(String text) in c:\BuildAgent\work\2be762a799648224\src\ServiceInsight.Desktop\CodeParser\BaseParser.cs:97
Particular.ServiceInsight.Desktop.CodeParser.CodeLexem.Parse(CodeLanguage lang) in c:\BuildAgent\work\2be762a799648224\src\ServiceInsight.Desktop\CodeParser\CodeLexem.cs:36
Particular.ServiceInsight.Desktop.CodeParser.CodeBlockPresenter.FillInlines(String text, InlineCollection collection, Brush brush) in c:\BuildAgent\work\2be762a799648224\src\ServiceInsight.Desktop\CodeParser\CodeBlockPresenter.cs:27
Particular.ServiceInsight.Desktop.MessageViewers.JsonViewer.JsonMessageView.Display(String message) in c:\BuildAgent\work\2be762a799648224\src\ServiceInsight.Desktop\MessageViewers\JsonViewer\JsonMessageView.xaml.cs:21
Particular.ServiceInsight.Desktop.MessageViewers.JsonViewer.JsonMessageViewModel.OnSelectedMessageChanged() in c:\BuildAgent\work\2be762a799648224\src\ServiceInsight.Desktop\MessageViewers\JsonViewer\JsonMessageViewModel.cs:35
Particular.ServiceInsight.Desktop.MessageViewers.JsonViewer.JsonMessageViewModel.set_SelectedMessage(MessageBody value):35
Particular.ServiceInsight.Desktop.MessageViewers.JsonViewer.JsonMessageViewModel.Handle(SelectedMessageChanged event) in c:\BuildAgent\work\2be762a799648224\src\ServiceInsight.Desktop\MessageViewers\JsonViewer\JsonMessageViewModel.cs:40

@distantcam distantcam added the Bug label Oct 17, 2014
@distantcam distantcam added this to the 1.2.1 milestone Oct 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant