Rogue message causes ServiceInsight to fall over

[CallumHibbert]

I've recently set-up ServiceInsight in a production environment. To test everything was working I used a console-based NSB application to send a test message directly to the audit queue that ServiceControl uses. ServiceControl picks up the message alright but when ServiceInsight tries to load the message it falls over (and exits) with the following error:

System.NullReferenceException: Object reference not set to an instance of an object.
   at Particular.ServiceInsight.Desktop.SequenceDiagram.MessageInfo.get_ReceivingEndpoint() in c:\BuildAgent\work\2be762a799648224\src\ServiceInsight.Desktop\SequenceDiagram\MessageInfo.cs:line 99
   at Particular.ServiceInsight.Desktop.SequenceDiagram.MessageInfo.UpdateIndicies() in c:\BuildAgent\work\2be762a799648224\src\ServiceInsight.Desktop\SequenceDiagram\MessageInfo.cs:line 216
   at Particular.ServiceInsight.Desktop.SequenceDiagram.MessageInfo.set_Endpoints(IEnumerable`1 value)
   at Particular.ServiceInsight.Desktop.SequenceDiagram.MessageInfo..ctor(IEventAggregator eventAggregator, IWindowManagerEx windowManager, Func`1 exceptionDetailViewModel, SequenceDiagramViewModel viewModel, StoredMessage message, ReactiveList`1 endpoints) in c:\BuildAgent\work\2be762a799648224\src\ServiceInsight.Desktop\SequenceDiagram\MessageInfo.cs:line 42
   at Particular.ServiceInsight.Desktop.SequenceDiagram.SequenceDiagramViewModel.<CreateMessages>b__a(StoredMessage m) in c:\BuildAgent\work\2be762a799648224\src\ServiceInsight.Desktop\SequenceDiagram\SequenceDiagramViewModel.cs:line 145
   at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at Particular.ServiceInsight.Desktop.SequenceDiagram.SequenceDiagramViewModel.CreateMessages(IEnumerable`1 messages) in c:\BuildAgent\work\2be762a799648224\src\ServiceInsight.Desktop\SequenceDiagram\SequenceDiagramViewModel.cs:line 145
   at Particular.ServiceInsight.Desktop.SequenceDiagram.SequenceDiagramViewModel.Handle(SelectedMessageChanged message) in c:\BuildAgent\work\2be762a799648224\src\ServiceInsight.Desktop\SequenceDiagram\SequenceDiagramViewModel.cs:line 92

I guess this error is because I sent the message directly to the audit queue, it is missing metadata that ServiceInsight is expecting to find.

I understand this is my fault as I sent the message directly but it would be possible for some to mis-configure an endpoint and do a similar thing to what I did but accidentally. This would cause problems in ServiceInsight.

For a better user experience, it might be sensible to handle such a situation so that ServiceInsight does not fall over (and maybe even warn the user that it looks like they are sending messages directly to the ServiceControl audit queue).

[distantcam]

Was this in 1.2.0 or 1.2.1?

[CallumHibbert]

1.2.1