Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a saga message does not contain SagaHistory, Improve the status bar error message #413

Closed
indualagarsamy opened this issue Nov 18, 2014 · 2 comments
Assignees
Labels
Milestone

Comments

@indualagarsamy
Copy link
Contributor

It is a valid scenario to have endpoints that contain saga information which does not load the SagaAudit plugin. When viewing these messages in ServiceInsight, the status bar reports an error.

screen shot 2014-11-17 at 7 00 19 pm

@indualagarsamy
Copy link
Contributor Author

@distantcam - I am having second thoughts on completely removing the status bar message for the following reasons:

However, it still makes sense to do a small improvement of changing the actual message we display in the status bar. Currently it says:
Operation Failed: Error executing the request: Data at the root level is invalid. Line1, position1., Status code is NotFound
I'd like to change it to the actual request, instead of the exception message.
So, it would be something like:
Operation Failed: Error executing the request: http://localhost:33333/api/sagas/<someguid>, Status code is NotFound

Proposed code change
Change Line 387 to

var errorMessage = response != null ? string.Format("Error executing the request: {0}, Status code is {1}", response.ResponseUri, response.StatusCode) : "No response was received.";

@indualagarsamy indualagarsamy changed the title When a saga message does not contain SagaHistory, the status bar reports a OperationFailed error When a saga message does not contain SagaHistory, Improve the status bar error message Nov 26, 2014
@johnsimons johnsimons added this to the 1.2.9 milestone May 29, 2015
@johnsimons
Copy link
Member

We are now not showing that error in the status bar, instead we load the tab but just display:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants