Fixing lint errors and making lint to be run on built (#1075)

.github/workflows/ci.yml

@@ -26,6 +26,9 @@ jobs:
       - name: Install Host npm packages
         run: npm run load
         working-directory: src/ServicePulse.Host
+      - name: Run lint
+        run: npm run lint
+        working-directory: src/ServicePulse.Host
       - name: Build
         run: msbuild src -p:Configuration=Release -restore -m
       - name: Upload assets

src/ServicePulse.Host/app/js/app.controller.js

@@ -166,7 +166,7 @@
                         });
                     }
                 });
-        };
+        }
 
         checkVersions();
 

src/ServicePulse.Host/app/js/views/custom_checks/customChecks.controller.js

@@ -57,6 +57,8 @@
                 $scope.pager.total = response.total;
             });
         }
+
+        reloadData();
     }
 
     controller.$inject = [

src/ServicePulse.Host/app/modules/configuration/js/notifications/notifications.service.js

@@ -1,11 +1,11 @@
 (function (window, angular) {
     'use strict';
-    
+
     function service($http, $timeout, $q, $rootScope, $interval, moment, connectionsManager, uri, notifications, notifyService) {
         var notifier = notifyService();
         var scu = connectionsManager.getServiceControlUrl();
 
-        var notifications = {};
+        notifications = {};
 
         function getData() {
             var url = uri.join(scu, 'notifications/email');
@@ -43,8 +43,8 @@
         return {
             updateSettings: function(settings, success, error) {
                 var url = uri.join(scu, 'notifications/email');
-                var promise = sendPromise(url, 'POST', settings, 
-                () => {notifications = settings}, 
+                var promise = sendPromise(url, 'POST', settings,
+                () => {notifications = settings},
                 error);
 
                 return promise;
@@ -57,7 +57,7 @@
             },
             toogleEmailNotifications: function(enabled, success, error) {
                 var url = uri.join(scu, 'notifications/email/toggle');
-                
+
                 var promise = sendPromise(url, 'POST', {'enabled': enabled}, success, error);
 
                 return promise;

src/ServicePulse.Host/app/modules/monitoring/js/directives/ui.particular.monitoringConnectivityStatus.js

@@ -1,4 +1,4 @@
-const { version } = require("zeroclipboard");
+require("zeroclipboard");
 
 (function (window, angular, $) {
     'use strict';
@@ -12,7 +12,7 @@
 
             const notifier = notifyService();
             $scope.isSCMonitoringConnecting = connectionsManager.getIsMonitoringEnabled();
-            
+
             if ($scope.isSCMonitoringConnecting) {
                 connectivityNotifier.reportConnecting();
             }