feat: encode Lua args as UTF-8 instead of ACP #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As SimpleGraphic and the Lua code moves toward UTF-8 encoding of narrow strings, this change is beneficial for launching PoB installed in locations with fancy characters in the path.
This was referenced Jan 19, 2025
Wires77
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As SimpleGraphic and the Lua code moves toward UTF-8 encoding of narrow strings, this change is beneficial for launching PoB installed in locations with fancy characters in the path.
It is part of a larger orchestrated effort that needs to ship at the same time as revised Lua code in the main repository and also with a SimpleGraphic update.