Add all new 0.3 skills and update old ones (#1257)

* Export stat descriptions

Adds logic to remove random unicode characters from tree/ stat description files
Example is the bullet point used on Hollow Palm and some other Keystones

* Add Support gem family

Also adds logic to only have 1 family gem actively supporting a skill

* Add logic for Lineage Supports

Changes the support gem count logic to now only look for lineage supports and add a warning if you have more than 1

* Stop crash on loading gems after export

The SkillType for repeating skills was changed to Barrageable

* Update export of skills gems list

Now has a dedicated file for the export of gems so it is much easier to see what has changed over time
Also fixes a number of issues with the layout of the export version so now it should be 100% correct
There are still a number of gems in the list that shouldn't exist though
Need to figure out some general logic to eliminate them

Should not appear in gem export list
SupportFusilladePlayer
Cast on Death
DarkTempestPlayer
HisFoulEmergencePlayer
ScatteringCalamityPlayer
VileDisruptionPlayer
HisWinnowingFlamePlayer
TriggeredHisWinnowingFlamePillarPlayer
RollingMagmaPlayer
SummonSkeletalSnipersPlayer - All minions here are duplicated
MetaSpellslingerPlayer
SupportSpellslingerPlayer
SupportFrozenVortexPlayer
TriggeredFrozenVortexPlayer
SupportHoarfrostPlayer
TriggeredHoarfrostPlayer
BlinkSandPlayer
RunicTemperingPlayer

* Active Strength gems

* Strength Support Gems

* Active Dexterity Gems

* Dexterity Support Gems

* Active Intelligence Gems

* Support Intelligence Gems

* Other Gems

* New minions / fix minion SkillTypes

* Fix loading of old gems

Changed the skill loading logic to use the game id and the first variant in the list if the name has changed between updates

* Fix Tests

---------

Co-authored-by: LocalIdentity <localidentity2@gmail.com>

Author: LocalIdentity

spec/System/TestAttacks_spec.lua

@@ -72,9 +72,9 @@ describe("TestAttacks", function()
 		runCallback("OnFrame")
 		-- Add 2 skills with 1 red, 1 blue, 1 green support each
 		-- Test against Quarterstaff Strike (skill slot 1)
-		build.skillsTab:PasteSocketGroup("Quarterstaff Strike 1/0  1\nSplinter 1/0  1\nConduction 1/0  1\nBiting Frost 1/0  1")
+		build.skillsTab:PasteSocketGroup("Quarterstaff Strike 1/0  1\nArmour Break I 1/0  1\nShock 1/0  1\nBiting Frost 1/0  1")
 		runCallback("OnFrame")
-		build.skillsTab:PasteSocketGroup("Falling Thunder 1/0  1\nIgnition 1/0  1\nDiscombobulate 1/0  1\nCoursing Current 1/0  1")
+		build.skillsTab:PasteSocketGroup("Falling Thunder 1/0  1\nIgnite I 1/0  1\nDaze 1/0  1\nShock Conduction 1/0  1")
 		runCallback("OnFrame")
 
 		build.configTab:BuildModList()

src/Classes/GemSelectControl.lua

@@ -542,6 +542,9 @@ function GemSelectClass:AddGemTooltip(gemInstance)
 	if gemInstance.gemData.tagString ~= "" then
 		self.tooltip:AddLine(16, "^x7F7F7F" .. gemInstance.gemData.tagString)
 	end
+	if gemInstance.gemData.gemFamily then
+		self.tooltip:AddLine(16, "^x7F7F7FCategory: ^7" .. gemInstance.gemData.gemFamily)
+	end
 	-- Will need rework if a gem can have 2+ additional supports
 	self:AddGrantedEffectInfo(gemInstance, grantedEffect, true)
 	for _, statSet in ipairs(grantedEffect.statSets) do
@@ -566,7 +569,7 @@ end
 function GemSelectClass:AddGrantedEffectInfo(gemInstance, grantedEffect, addReq)
 	local displayInstance = gemInstance.displayEffect or gemInstance
 	local grantedEffectLevel = grantedEffect.levels[displayInstance.level] or { }
-	if gemInstance.gemData.Tier then
+	if gemInstance.gemData.Tier and not grantedEffect.isLineage then
 			self.tooltip:AddLine(16, string.format("^x7F7F7FTier: ^7%d", gemInstance.gemData.Tier))
 		end
 	if addReq and not grantedEffect.support then

src/Classes/ModStore.lua

@@ -407,6 +407,9 @@ function ModStoreClass:EvalMod(mod, cfg, globalLimits)
 			else
 				base = target:GetStat(tag.stat, cfg)
 			end
+			if tag.divVar then
+				tag.div = self:GetMultiplier(tag.divVar, cfg)
+			end
 			local mult = m_floor(base / (tag.div or 1) + 0.0001)
 			local limitTotal
 			if tag.limit or tag.limitVar then

src/Classes/SkillsTab.lua

@@ -287,16 +287,14 @@ function SkillsTabClass:LoadSkill(node, skillSetId)
 			local possibleVariants = self.build.data.gemsByGameId[child.attrib.gemId]
 			if possibleVariants then
 				-- If it is a known gem, try to determine which variant is used
-				if child.attrib.variantId then
+				if child.attrib.variantId and possibleVariants[child.attrib.variantId] then
 					-- New save format from 3.23 that stores the specific variation (transfiguration)
 					gemData = possibleVariants[child.attrib.variantId]
-				elseif child.attrib.skillId then
-					-- Old format relying on the uniqueness of the granted effects id
+				else
+					-- If a gem has changed names between updates, assumed it's the first gem in the list
 					for _, variant in pairs(possibleVariants) do
-						if variant.grantedEffectId == child.attrib.skillId then
-							gemData = variant
-							break
-						end
+						gemData = variant
+						break
 					end
 				end
 			end
@@ -1324,6 +1322,7 @@ function SkillsTabClass:UpdateGlobalGemCountAssignments()
 						GlobalGemAssignments[gemInstance.gemData.name] = { 
 							count = 1,
 							support = gemInstance.gemData.grantedEffect and gemInstance.gemData.grantedEffect.support or false,
+							lineage = gemInstance.gemData.grantedEffect and gemInstance.gemData.grantedEffect.isLineage or false,
 							groups = { } 
 						}
 						if socketGroup.displayLabel then