-
Notifications
You must be signed in to change notification settings - Fork 224
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the value from the calculation in-game?
In PoB2 Sunder's +100% critical damage bonus seems to be acting as a x2 multiplier to all other sources of critical damage bonuses. From jewels or the passive tree. When I believe it should be a flat +100%, not a x2 to all other values (This assumption is based off of the in game dps calculations page).
What is the value from the calculation in Path of Building?
Base Crit Dmg Bonus + Sunder Crit Bonus (100%) * (All Other Crit Dmg Bonuses)
100% + 2 * (Sum of Other Sources %)
How to reproduce the issue
Select Sunder as main skill, observe 300% starting crit value instead of 200% (Expected).
Then select any other crit damage bonus node or insert a Jewel with crit dmg bonus, and observe 2x increase to crit dmg bonus than expected. (Eg: take the "Attack Critical Damage" small node near Overwhelming Strike towards the bottom left of the passive tree and the displayed crit dmg bonus will increase to 330% instead of expected 315%).
Character build code
eNq1W21v2zgS_tz8CsHAAXeAk1iSX4NkF47tpLmzG5-dpnf7ZcFItM0tJboS5cQt-t9vSOrNrilLDm4LtLI4z7xxOOQMtde_v3nU2OAgJMy_qZkXjZqBfYe5xF_e1D4_3Z13a7__dnY9RXz1uLiNCBUj1m9nH67lD4PiDaYAtGqGQ1EYfkIevql9QUFAWFAzUOhg3x1kI0-EI79mcBQsMX9O5Db-NAG_QgFyOA7Ggmc_4mzCXIDwIMI1w0PEnzPnK-b3AYvWILJmbAh-VTQPk-nj7KkGen24nlK0xcGcI26E8NdNrQ_2oSUeIg_-BhSiEUCaFy2z27NbPbNt2nardlkIvo2CkJ_GYb7G2E1BjYumbTc6jW67bTbNjq1DTQM8Wiyww8kGDwLCByvkO5lsrbQDtI2LViH5JKKcrCnBQQqxLzo6xMdf-JumjvaJcUSH03lGetFrdRpmr9kzLbvbK8YxnplwjDIvREs8iCiF8C1FO8MhDjaIQ3yW4828F-Jjt79ZVg6xAKPHhZrtGXJJFE4wD3CYm0CtpybIRwMWZp5qNopIpziABcl3EMcAc-wwWMN5iNm5sC2razfbzVa73Ssh8TAfregxWeDylJWsigFVtTnNjtG8LF1lxqcpNIMEVo5yziJakpJniaNTsKC-7RC2dYRD_JZR6YgefH6caIg3TCzgkmlk9HGaUlpt-6LdaHUsyFe9nlbX6WobEgfRCXojXuRBbnxCX3EmEFaIPqiWK-5DOtJhraalw96RAJ8AGzDqngJbIRaeYOEEtuyPyHf7jhPBzr5NMe1u0Uorwxr2VOdKED_4TkpfyPWzH8iMntuKCydngWewrMTm_0JxWUgmJF6dWcZsNIplLbEfC9yWS0hjjJ3VPbgYRMGslEvnKVXPKnStoM27tpDpAdfq2e8CKrhJAA-7qeCwIkCVHTVfk4CU0klRHrC_AqaCC0Y-Dpbb-Ypg6pbYInLUic8GaF3GfoiAPLpUJOyKqxTOeWjl2YJawy2371XVaoPC_OZhH3GYIi-3ajDFGAAu3j-q68sB9pcoBmg1WD_wWBSUnHJFXMqAZN9TFdEMu5FTbqNNa5pbCsVcWTNSFOhJaSVon3PkfB0yd1naaVJIJcSufvNovYbVLaKhLAOxoUPFQXLHrfNmCepHCOVSa1ps_eUFZNSlBaTHmfJS9iDlbRHnkT0xZYhLC0incwKpwoPkLEv4Ccvld-3UQIlZql6UhCXr1il7Bc1XomcSVqOGU1uWv7SqBNj_vi3Nf4e8lICR78IBEBZCaRn7iENibqPFIjQcqLsRH8P03tRqxgu8S57h0Bni-IdCPBEPEm8YDhFHxl_4FdOn7Ro_uLKZ5MbFwjMKCPK5JV9KItV2EmRWu2O1akaIUeCsBOs7ROkL5BchL3srfu2xMyU7qNO-RThgQSZXaHZ9KZtp4unBW7OAG_hN_DNFAd_e1BaIhlgRyjfAO-TEl70JSHCU1oz5ir323Y3w2BNjNExABlqvse_u8HgKMDZQkq4coYT0jvhheCjksDuqFRAKQ3ItvNhTPgMF4BRvm2az3mp2TbNud23LrttWy27WTdvuderSVfVmx-y06pZpd-FNx-7Y8N7stOum1ejU7Z7drrc6nYZdb9kds1c3JcayelZXuFNUtSjY9ncV8AnYy8GGve5hpqCw5sP159lYPnxYcb4Ory4vX19fL9aIr9gCv8E-egGRc7kGEPjhPPxKKD0XXC_78N_tcnQ73KB_mavoOfw-e0b3z0_ECvgfX_sj_tpbNr8sZmbj7vnLH4L65kYKvEwkXquACZX4-Jf0Wi6GCMee-Bl3hQCeR12LXBUQ8HPMBLaxgLxEHCcDEARvn9READOfp88hD-JnNSlqOqTD1Yyp2VAeV7On5iD2vpolOQeJZjvKgKIQKDJqRSSJh0-MqzHxMvlxPRc-DY0QAvkee-HtFnLdnTjiZc0ymf3iUBTUc8xlhO1gkg6wixcoouL9vyNEiVgZMhay92PVjPZZ4KUlOTCDtSG2ZMVTrDzwTX88jqM-lmuQXOzIl7Ll3M-UGyDqhFI94js0gtn042wfK0LRixAvOuiiaHTzrescHwiBWjyroI9MeCD_wYcJjRkp_D1lL4haCZe4097bHTaT4Y3KMyKkxhit5xQJ04W8_CuVaGvGt8SDVqNmLFUkTjBHLmTGywcIzfBS-P9SKiw9m7D0kRenDfHOUC_3DHZY5PPUm8KfORuNJSR2jl2VYuC0FcHbIFGMKDfE-6uINpCe89Y7XaOE5RyzKz11SzmvJNwynyRvdA5J17rgEK-mOADlilJrRjzKaJMUD_464lLGTc0jofOn2OTEtYdc6_KiZnR3Nxo8PTyP4o0uD5Gm_ulH3otUVf6bHWDmWB7cjTB6CdXjTe2Z4FepyBBsJzQU-lOK1iFONxK5WmLNKeAKuEkqqOSSy5PDvDICPafRGw5g31tCxecEBGv1SsePKKUEimpQHAx03MQ1hJ6RKi8GsGvOENfyUFdAei7iFkZrjhgswMKJAVGt5Hj0iCe4SIoQwGRBHLFWi6dcpFBFVeCXtOenne-4NtLzuKXy4uwwAzWoB08ZCUVBehgdjxZ4dekT_XzGo3r4EDtIa7sa1IPTFgjzZQfkMJeUqoDTJ-bLIIdF0ydUVDLamR1RnJLoGT7yFQ7iw6GO0wRyVEJSuHDUgUbLJ0dR4CvZMNZ4SIzpoaofqrFBjBUsmrhDqFvtpHjJ7vbxNPORp9GzUt0vbR4sgqqiWOv-uMAumMG4t6SZPTVa4ISkvaaxPx4uWGMyffc3jLiqyaJZbXtkRfkGTuDvZyM7R-9ns99Kej_HOyiRvmrnOx7Vwz9zIg5HB7ioQ04pJmJNvo-DWJrv4yB6Ct7J6Nn-KSbDzorPL2n34yA4GS1KG3FT5GQOqnVzMlx2lk5Gy71jiBcYLCjcPFKagsXBI38IzuAFC6MkK6nW4SySWVeJl9pGD1pamaNa3fGVa1ECUCRHGME54GPBSbMcp7Q7-hEjyldTxuj7GP5ytfweZuJ-J1oj303YPR4632fzUNJ7jIfAU7bphuIa6b0-9LG3PcBIr9f1ZVIRygaeqNHijuOcB6Lp8J0x7783tfNeo3th2mav3WvYna6tBsbZZ3qyHQKn9yGBeQxk_CVyBeV_gMrudC66ZrtnNVp2_IXatSx_416NeE5bNXp2UYjVpylfMFozXyJEf0OVqMAj33OZQZHOt1fGp8fZpD8-G2PkYt-4DzDiK-R5ODiLuz5XhtU4i3tlV8Zc_DmbRT4GKPOx5lHaP8PfrgzbPoOaiBKHCHhDluBCl12lrF2lJv37h8GZiKLzMQu5MUfr9YoEeJfVD46W4ZUrJ64OFSgXN2Q_fzhRyJn38wek7iW-Mn_-vXVuNv7xN9FFAutg2o1BTGuoSTdumR-FslEAZf5MwAwJVs0nN6veD2jeLNZ8BJ5E1N1TPFbx83oZgNtDQ32FZnBmjEVWjy1DstZ9v2XGggWGKpzj90W2Wnpb7WJbZ9HLtrShEwxP3u4cKoMP2GmeWztmyvvc99nSOmTL--LMbJxb_5dAE-1S3eLe7aNSxmWne_ryeTYWWUr1pO4p24idMWmCN5LGmA6ghBhmBjGPQeRBLo84KqTvRRTzCgB5kDTsyogqSikzrOq-qgK5xZSfMBvG_FVcp5bGzeD8UU0v5m6NpM78FRXfywFk_3ZFwf8pbu-M3IVLwr6kB0-yz6wcDlU88hHD4ZJXciHjv640taCTrrPc22XTmfkLsox3efUj3uclKH2zs8inFDl4xaiLg1gmFqeb-LP3pOHcaaSqagA71_oJ7Bgo_YYgaS-nDe6GZR0TmPtUPoG19Jj5CuJtLnaE8Jc-ul4GvDlBNfGFxwkweczJEN2mnt5LP_r_QkTVgl1p2kDcVMwxXeTktkrYuD9vrdITNxUn_gRml0VVlieja9-lzUbvCCztUqU-LXJq6o5KRok43NfMLrBn7jB57C8diSFZEvq4kOU7wGQPomwAJ9k3pbe6vWO-3v06rFIExx-UQUUkjyP5_FFiyVRye_6bq_0wgmoryXWq9pK_fju7vvzl_4T6H0TbJ_Y=
