Skip to content

Fix Arc skill on Storm Mages not working #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Apr 14, 2025
Merged

Fix Arc skill on Storm Mages not working #1004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Data/Skills/minion.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,10 +335,10 @@ skills["ArcSkeletonMageMinion"] = {
"disable_visual_hit_effect",
},
levels = {
[1] = { 1, 9, 2, statInterpolation = { 1, 1, 1, }, actorLevel = 1, },
[2] = { 5, 103, 3, statInterpolation = { 1, 1, 1, }, actorLevel = 20, },
[3] = { 21, 408, 4, statInterpolation = { 1, 1, 1, }, actorLevel = 40, },
[4] = { 66, 1260, 5, statInterpolation = { 1, 1, 1, }, actorLevel = 60, },
[1] = { 0.10000000149012, 1.8999999761581, 2, statInterpolation = { 3, 3, 1, }, actorLevel = 1, },
[2] = { 0.10000000149012, 1.8999999761581, 3, statInterpolation = { 3, 3, 1, }, actorLevel = 20, },
[3] = { 0.10000000149012, 1.8999999761581, 4, statInterpolation = { 3, 3, 1, }, actorLevel = 40, },
[4] = { 0.10000000149012, 1.8999999761581, 5, statInterpolation = { 3, 3, 1, }, actorLevel = 60, },
},
},
}
Expand Down
2 changes: 1 addition & 1 deletion src/Export/Scripts/skills.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,7 +733,7 @@ directiveTable.set = function(state, args, out)
statMapOrderIndex = statMapOrderIndex + 1
end
end
if resolveInterpolation and #statsPerLevel > 1 then -- Don't resolve values for minion skills as it will break them
if resolveInterpolation and #statsPerLevel > 5 then -- Don't resolve values for minion skills as it will break them
table.insert(level, statRow.BaseResolvedValues[i])
if state.skill.setIndex ~= 1 then
-- Modify the correct statInterpolation value in the current set by offsetting the value from the count in the base set
Expand Down
2 changes: 1 addition & 1 deletion src/Modules/CalcTools.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ function calcLib.buildSkillInstanceStats(skillInstance, grantedEffect, statSet)
if statSetLevel.statInterpolation[index] == 3 then
-- Effectiveness interpolation
if not availableEffectiveness then
actorLevel = #statSet.levels == 1 and skillInstance.actorLevel or statSetLevel.actorLevel
actorLevel = #statSet.levels < 5 and skillInstance.actorLevel or statSetLevel.actorLevel
availableEffectiveness =
data.gameConstants["SkillDamageBaseEffectiveness"] * (statSet.baseEffectiveness or 1)
* (1 + (statSet.incrementalEffectiveness or 0) * (actorLevel - 1))
Expand Down