Add all new 0.3 skills and update old ones #1257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
September 2, 2025 03:06
Adds logic to remove random unicode characters from tree/ stat description files Example is the bullet point used on Hollow Palm and some other Keystones
Also adds logic to only have 1 family gem actively supporting a skill
Changes the support gem count logic to now only look for lineage supports and add a warning if you have more than 1
The SkillType for repeating skills was changed to Barrageable
Now has a dedicated file for the export of gems so it is much easier to see what has changed over time Also fixes a number of issues with the layout of the export version so now it should be 100% correct There are still a number of gems in the list that shouldn't exist though Need to figure out some general logic to eliminate them Should not appear in gem export list SupportFusilladePlayer Cast on Death DarkTempestPlayer HisFoulEmergencePlayer ScatteringCalamityPlayer VileDisruptionPlayer HisWinnowingFlamePlayer TriggeredHisWinnowingFlamePillarPlayer RollingMagmaPlayer SummonSkeletalSnipersPlayer - All minions here are duplicated MetaSpellslingerPlayer SupportSpellslingerPlayer SupportFrozenVortexPlayer TriggeredFrozenVortexPlayer SupportHoarfrostPlayer TriggeredHoarfrostPlayer BlinkSandPlayer RunicTemperingPlayer
added 2 commits
September 2, 2025 14:20
Changed the skill loading logic to use the game id and the first variant in the list if the name has changed between updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds all the new skill gems and updates old ones
Adds logic to remove random Unicode characters from tree/ stat description files
e.g. the bullet point used on Hollow Palm and some other Keystones
Adds support gem families and logic to only have 1 family gem actively supporting a skill
Add lineage supports and change the support gem count logic to now only look for lineage supports, and add a warning if you have more than 1
Revamp skill gem export list script
Now has a dedicated file for the export of gems, so it is much easier to see what has changed over time
Also fixes several issues with the layout of the export version, so now it should be 100% correct
There are still some gems in the list that shouldn't exist
Should not appear in gem export list:
SupportFusilladePlayer
Cast on Death
DarkTempestPlayer
HisFoulEmergencePlayer
ScatteringCalamityPlayer
VileDisruptionPlayer
HisWinnowingFlamePlayer
TriggeredHisWinnowingFlamePillarPlayer
RollingMagmaPlayer
SummonSkeletalSnipersPlayer - All minions here are duplicated
MetaSpellslingerPlayer
SupportSpellslingerPlayer
SupportFrozenVortexPlayer
TriggeredFrozenVortexPlayer
SupportHoarfrostPlayer
TriggeredHoarfrostPlayer
BlinkSandPlayer
RunicTemperingPlayer