Skip to content

Fix minion Gas Arrow skill not showing Poison / Explode damage #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Sep 13, 2025
Merged

Fix minion Gas Arrow skill not showing Poison / Explode damage #1372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Data/Skills/minion.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ skills["GasShotSkeletonSniperMinion"] = {
incrementalEffectiveness = 0.054999999701977,
statDescriptionScope = "sniper_gas_shot_statset_2",
baseFlags = {
attack = true,
hit = true,
area = true,
},
Expand Down
2 changes: 1 addition & 1 deletion src/Export/Skills/minion.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ local skills, mod, flag, skill = ...
#flags attack area duration
#mods
#set GasShotCloudExplodeSkeletonSniperMinion
#flags hit area
#flags attack area
#mods
#skillEnd

Expand Down
6 changes: 4 additions & 2 deletions src/Modules/CalcActiveSkill.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,8 +967,10 @@ function calcs.createMinionSkills(env, activeSkill)
}
local minionSkillIndex = activeSkill.activeEffect.srcInstance.skillMinionSkill
local minionSkillIndexCalcs = activeSkill.activeEffect.srcInstance.skillMinionSkillCalcs
local minionStatSetIndex = activeSkill.activeEffect.srcInstance.minionStatSet and activeSkill.activeEffect.srcInstance.minionStatSet[activeSkill.activeEffect.grantedEffect.id][minionSkillIndex] or 1
local minionStatSetCalcsIndex = activeSkill.activeEffect.srcInstance.minionStatSetCalcs and activeSkill.activeEffect.srcInstance.minionStatSetCalcs[activeSkill.activeEffect.grantedEffect.id][minionSkillIndexCalcs] or 1
local minionStatSetIndex = activeSkill.activeEffect.srcInstance.skillMinionSkillStatSetIndexLookup and activeSkill.activeEffect.srcInstance.skillMinionSkillStatSetIndexLookup[activeSkill.activeEffect.grantedEffect.id]
and activeSkill.activeEffect.srcInstance.skillMinionSkillStatSetIndexLookup[activeSkill.activeEffect.grantedEffect.id][minionSkillIndex] or 1
local minionStatSetCalcsIndex = activeSkill.activeEffect.srcInstance.skillMinionSkillStatSetIndexLookupCalcs and activeSkill.activeEffect.srcInstance.skillMinionSkillStatSetIndexLookupCalcs[activeSkill.activeEffect.grantedEffect.id]
and activeSkill.activeEffect.srcInstance.skillMinionSkillStatSetIndexLookupCalcs[activeSkill.activeEffect.grantedEffect.id][minionSkillIndexCalcs] or 1
activeEffect.statSet = {
index = minionStatSetIndex,
}
Expand Down