Add support for Harness the Elements notable and Electrocute to config tab #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrzp
force-pushed
the
enable-harness-the-elements
branch
2 times, most recently
from
3733e62 to
d3dd66d
Compare
deathbeam
reviewed
Jan 20, 2025
src/Modules/ConfigOptions.lua
Outdated
| @@ -1565,6 +1565,10 @@ Huge sets the radius to 11. | |||
| { var = "ShockStacks", type = "count", label = "^xADAA47Shock ^7Stacks", ifFlag = "ShockCanStack", ifOption = "conditionEnemyShocked", defaultPlaceholderState = 1, tooltip = "Amount of stacks of ^xADAA47Shock ^7applied to the enemy.", apply = function(val, modList, enemyModList) | |||
| enemyModList:NewMod("Multiplier:ShockStacks", "BASE", val, "Config", { type = "Condition", var = "Effective" }) | |||
| end }, | |||
| { var = "conditionEnemyElectrocuted", type = "check", label = "Is the enemy ^xADAA47Electrocuted?", apply = function(val, modList, enemyModList) | |||
Collaborator
There was a problem hiding this comment.
this should have ifEnemyCond = "Electrocuted"
lrzp
force-pushed
the
enable-harness-the-elements
branch
from
d3dd66d to
2bfc7d4
Compare
LocalIdentity
approved these changes
Jan 20, 2025
LocalIdentity
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Harness the Elements and add Electrocute to the config
Description of the problem being solved:
Harness the Elements mod added to the parser. Electrocute added to config as it's a new elemental ailment
Steps taken to verify a working solution: