improve implementation of Kaom's Heart 'You have no spirit' mod. #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ged mod parsing, mod calculation to consider the override and calculate negative spirit, and calc sections to display the override on the calc panel
LocalIdentity
approved these changes
Jan 20, 2025
LocalIdentity
merged commit 903ad1e
into
PathOfBuildingCommunity:dev
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow the calculation and display of negative unreserved spirit and the warning associated with it. it also adds a line in the calcs panel in this scenario that shows where the override is coming from.
The linked build also has negative life and mana custom modifiers to make sure the life/mana reservation code is unnaffected in those cases.
Link to a build that showcases this PR:
https://pobb.in/kglYQAEZMgvn
After screenshot: