Added support for Minions resistances are equal to yours #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Removed the maximum resistance changes to minions. As it is, it takes players capped resistances, and caps it to the minions max resistance. E.g. Player max fire resistance is 76. Minions is 75, so minion stat shows 75% fire res with 1% overcap. |
LocalIdentity
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description of the problem being solved:
Carrion Call unique shield has the mod "minions' resistances are equal to yours". This works, but looking for clarification on stuff.
Not totally sure on exactly how it functions. As you can see, the minion gets my 76% resistance, even though it says MAX 75. I can't get that to function in pob without just overriding the max res to 76. Understandable though.
Other thing I'm unsure of, is whether the minion gets player capped resist, or overcapped resist. I see nowhere on the minion page to see the minions overcapped res, so I'm not sure how we can tell.
Also, the code is pretty straight forward, but not very compact. If there is a better way to do this let me know!
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/hj5lf0fj
Before screenshot:
After screenshot: