Fix comparison tooltips for builds with Time-Lost Jewels #709
Conversation
|
im sorry im pretty new to this. does this mean it would be fixed next update?. |
|
@kattpess If merged, yeah it'll be in the next update. |
feel so stupid, dont even know what merged means :(. Anyway appreciate what you guys are going to the pob community, thanks |
|
@kattpess it'll be in the next update, I'm hoping to release it tonight along with some other fixes too |
|
@kattpess No worries, so this is a request to make a change to the code. A maintainer, LocalIdentity or Wires, has to review and approve it for it to be merged into the code, and then when we release an update, it contains all the changes to the code aka merged pull requests since the last update. |
Ahh, so people that know how to write these codes etc could do it?,like anyone ? and then Locall or the main admins need to approve it?. Thats pretty nice!. i realy need to use the web for what it is and not just reading newpapirs. Again, big thanks for the work you guys put in to this. and thanks explaining it. best wishes and take care both. |
|
sry for dumb question, since its green on run_tests and spellcheck, does that mean its fixed? |
|
@kattpess Last release was 5 days ago, this was only fixed 2 days ago. It's fixed, but not in your PoB until the next release. |
|
thanks for clearing that out, was going thinking my pob was wrong or i have downloaded wrong one. |
Peechey
deleted the
fix/jewel-comparison-tooltips-with-timelost-jewels
branch
4 participants
Fixes #704
Fixes #707
Description of the problem being solved:
There's an old skipProcessing flag in the code around timeLost jewel logic that we were using before the caching fix introduced in 0.4.0. The issue with this is every comparison was "missing" the timeLost jewel mods so the comparison always thought the jewel was being removed regardless of the item. This PR removes the flag entirely as it doesn't seem we really need it anymore anyways thanks to the caching solution.
Link to a build that showcases this PR:
707
704
Some older builds back in the caching PR days
Before screenshot:
After screenshot: