Add support for War Banner aura mods #752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description of the problem being solved:
War Banner aura was not implemented yet, it now applies the increased accuracy and more damage for attacks, and scales with valour stacks.
Valour stack is currently not limited in the config. It should be limited to 50 as base, but unsure if there is anything that alters the max stackable valour.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/na9lh05n
Before screenshot:
After screenshot:
-Valour 50, no quality on gem
-Valour 50, 20 quality