Add support for Defiance Banner #753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Feb 10, 2025
Blitz54
added a commit
to Blitz54/PathOfBuilding-PoE2
that referenced
this pull request
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description of the problem being solved:
Defiance Banner has more "more armour and evasion" as well as "increased movement speed" mods. Both scale by Valour stacks. Should work here.
Quality for defiance banner is not yet implemented. Mana Tempest uses the same stat. Seems weird to be on Defiance banner, does the banner count as empowering? I didn't think so, but dunno.
Also small text edit for Magnetic Salvo. They switched arrows and bolts at one point, likely because they repeat the order in a later sentence.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/1s9k707b
Before screenshot:
After screenshot:
50 stack, 20 gem
0 Stack, 20 gem
Salvo Text
