Add support for Candlemaker "chance to ignite is doubled" #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Feb 12, 2025
Contributor
|
Not important for now, but this mod, as well as all the other "doubled" modifiers might need to work via either multipliers with a limit and/or some kind of flags to prevent them applying multiple times. The specific "double" or "triple" wording usually implies that they are not multiplicative with other sources and only the highest applies. I don't think there's currently more than one source of "doubled" for all the affected stats in PoE2, but if there was, they'd multiply in PoB if you had more than one. (can easily test this by entering Just thought I'd mention it, in case we see more "doubled" or even "tripled" mods in the future |
Blitz54
added a commit
to Blitz54/PathOfBuilding-PoE2
that referenced
this pull request
Feb 25, 2025
Blitz54
added a commit
to Blitz54/PathOfBuilding-PoE2
that referenced
this pull request
Feb 25, 2025
Blitz54
added a commit
to Blitz54/PathOfBuilding-PoE2
that referenced
this pull request
Feb 25, 2025
Blitz54
added a commit
to Blitz54/PathOfBuilding-PoE2
that referenced
this pull request
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description of the problem being solved:
Candlemaker unique gloves have "chance to ignite is doubled". Everything else that I see that is "doubled" uses a 100% MORE mod. So that's what I did here.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/sf3d800z
Before screenshot:
After screenshot: