Skip to content

Update Unholy Might effect and tooltip #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LocalIdentity merged 1 commit into from
Apr 1, 2025
Merged

Update Unholy Might effect and tooltip #854

LocalIdentity merged 1 commit into from
Apr 1, 2025

Conversation

@majochem
Copy link
Contributor

@majochem majochem commented Mar 31, 2025

Fixes #853 .

Description of the problem being solved:

  • Change Unholy Might buff to use PoE2 effects instead: 30% of all damage gained as extra chaos damage (no more connection to Wither)
  • Updated tooltips in the ConfigOptions
  • Also added UnholyMightMagnitude into calculation already for the upcoming Lich node "Blackened Heart"

Steps taken to verify a working solution:

  • Damage is added
  • Phys damage no longer converted
  • Unholy Might no longer enables "Wither" config options

After screenshot:

image
image

@majochem majochem marked this pull request as ready for review March 31, 2025 19:50
@LocalIdentity LocalIdentity added bug: accuracy Wording differences bug: behaviour Behavioral differences and removed bug: accuracy Wording differences labels Apr 1, 2025
@LocalIdentity LocalIdentity merged commit 24a0da0 into PathOfBuildingCommunity:dev Apr 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LocalIdentity LocalIdentity LocalIdentity approved these changes

Assignees

No one assigned

Labels

bug: behaviour Behavioral differences

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unholy Might buff in PoE2

2 participants

@majochem @LocalIdentity