Skip to content

Add support for Elemental Storm and Solar Orb hit rate #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

Add support for Elemental Storm and Solar Orb hit rate #866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Data/Skills/act_int.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15076,6 +15076,12 @@ skills["SolarOrbPlayer"] = {
incrementalEffectiveness = 0.14000000059605,
damageIncrementalEffectiveness = 0.0065000001341105,
statDescriptionScope = "solar_orb_statset_0",
statMap = {
["solar_orb_base_pulse_frequency_ms"] = {
skill("hitTimeOverride", nil),
div = 1000,
},
},
baseFlags = {
spell = true,
area = true,
Expand Down
24 changes: 24 additions & 0 deletions src/Data/Skills/other.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,6 +990,12 @@ skills["ElementalStormPlayer"] = {
incrementalEffectiveness = 0.14000000059605,
damageIncrementalEffectiveness = 0.0065000001341105,
statDescriptionScope = "tornado_triggered",
statMap = {
["tornado_base_damage_interval_ms"] = {
skill("hitTimeOverride", nil),
div = 1000,
},
},
baseFlags = {
area = true,
duration = true,
Expand Down Expand Up @@ -1058,6 +1064,12 @@ skills["ElementalStormPlayer"] = {
incrementalEffectiveness = 0.14000000059605,
damageIncrementalEffectiveness = 0.0065000001341105,
statDescriptionScope = "tornado_triggered",
statMap = {
["tornado_base_damage_interval_ms"] = {
skill("hitTimeOverride", nil),
div = 1000,
},
},
baseFlags = {
spell = true,
area = true,
Expand Down Expand Up @@ -1129,6 +1141,12 @@ skills["ElementalStormPlayer"] = {
incrementalEffectiveness = 0.14000000059605,
damageIncrementalEffectiveness = 0.0065000001341105,
statDescriptionScope = "tornado_triggered",
statMap = {
["tornado_base_damage_interval_ms"] = {
skill("hitTimeOverride", nil),
div = 1000,
},
},
baseFlags = {
spell = true,
area = true,
Expand Down Expand Up @@ -1200,6 +1218,12 @@ skills["ElementalStormPlayer"] = {
incrementalEffectiveness = 0.14000000059605,
damageIncrementalEffectiveness = 0.0065000001341105,
statDescriptionScope = "tornado_triggered",
statMap = {
["tornado_base_damage_interval_ms"] = {
skill("hitTimeOverride", nil),
div = 1000,
},
},
baseFlags = {
spell = true,
area = true,
Expand Down
6 changes: 6 additions & 0 deletions src/Export/Skills/act_int.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,6 +955,12 @@ statMap = {
#skill SolarOrbPlayer
#set SolarOrbPlayer
#flags spell area duration
statMap = {
["solar_orb_base_pulse_frequency_ms"] = {
skill("hitTimeOverride", nil),
div = 1000,
},
},
#mods
#set SolarOrbAuraPlayer
#flags spell area duration
Expand Down
24 changes: 24 additions & 0 deletions src/Export/Skills/other.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,39 @@ statMap = {
#skill ElementalStormPlayer
#set ElementalStormPlayer
#flags area duration
statMap = {
["tornado_base_damage_interval_ms"] = {
skill("hitTimeOverride", nil),
div = 1000,
},
},
#mods
#set ElementalStormFirePlayer
#flags spell area duration
statMap = {
["tornado_base_damage_interval_ms"] = {
skill("hitTimeOverride", nil),
div = 1000,
},
},
#mods
#set ElementalStormLightningPlayer
#flags spell area duration
statMap = {
["tornado_base_damage_interval_ms"] = {
skill("hitTimeOverride", nil),
div = 1000,
},
},
#mods
#set ElementalStormColdPlayer
#flags spell area duration
statMap = {
["tornado_base_damage_interval_ms"] = {
skill("hitTimeOverride", nil),
div = 1000,
},
},
#mods
#skillEnd

Expand Down