Add support for Retreat, Pursuit, and Blindside #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Added two configs, one for melee hit recently, and one for projectile attack hit recently. The gems look for 8 seconds, but I think we decided to implement anything from 8 seconds as recent for now. I abbreviated Projectile Attacks so that the line fit in the box. But maybe different wording would be fine? Kept it consistent for now.
Blindside gives MORE crit bonus and crit chance against blinded enemies.
Retreat and Pursuit use the new configs. They also prevent the skill from dealing melee or projectile damage. Equipping both gems on Falling Thunder makes it deal no damage at all, as it has a Melee and Projectile portion.