From 6ed2c7981e817f82625addf7bd9c50c81d3723a4 Mon Sep 17 00:00:00 2001 From: dreais <55636511+dreais@users.noreply.github.com> Date: Tue, 30 Jul 2024 06:35:20 +0200 Subject: [PATCH] Fixes Rupture using the wrong stat for damage taken and Bleed duration (#8030) * damage_taken and expire_rate were inversed, resulting in wrong effective dps modifier * fix for incorrect "quicker bleedd" from rupture * forgot to change rupture duration type to match the calculation * Update CalcOffence.lua * Fix Export --------- Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com> Co-authored-by: LocalIdentity --- src/Data/Skills/sup_dex.lua | 4 ++-- src/Export/Skills/sup_dex.txt | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Data/Skills/sup_dex.lua b/src/Data/Skills/sup_dex.lua index c9110309d0..086aa82210 100644 --- a/src/Data/Skills/sup_dex.lua +++ b/src/Data/Skills/sup_dex.lua @@ -3133,10 +3133,10 @@ skills["SupportRupture"] = { excludeSkillTypes = { }, statDescriptionScope = "gem_stat_descriptions", statMap = { - ["support_rupture_bleeding_time_passed_+%_final"] = { + ["support_rupture_bleeding_damage_taken_+%_final"] = { mod("DamageTaken", "MORE", nil, 0, KeywordFlag.Bleed, { type = "GlobalEffect", effectType = "Debuff" }, { type = "Multiplier", var = "RuptureStack", limit = 3 }) }, - ["support_rupture_bleeding_damage_taken_+%_final"] = { + ["support_rupture_bleeding_time_passed_+%_final"] = { mod("BleedExpireRate", "MORE", nil, 0, KeywordFlag.Bleed, { type = "GlobalEffect", effectType = "Debuff" }, { type = "Multiplier", var = "RuptureStack", limit = 3 }) }, ["critical_strikes_that_inflict_bleeding_also_rupture"] = { diff --git a/src/Export/Skills/sup_dex.txt b/src/Export/Skills/sup_dex.txt index 44a6d54318..23a2986523 100644 --- a/src/Export/Skills/sup_dex.txt +++ b/src/Export/Skills/sup_dex.txt @@ -376,10 +376,10 @@ local skills, mod, flag, skill = ... #skill SupportRupture statMap = { - ["support_rupture_bleeding_time_passed_+%_final"] = { + ["support_rupture_bleeding_damage_taken_+%_final"] = { mod("DamageTaken", "MORE", nil, 0, KeywordFlag.Bleed, { type = "GlobalEffect", effectType = "Debuff" }, { type = "Multiplier", var = "RuptureStack", limit = 3 }) }, - ["support_rupture_bleeding_damage_taken_+%_final"] = { + ["support_rupture_bleeding_time_passed_+%_final"] = { mod("BleedExpireRate", "MORE", nil, 0, KeywordFlag.Bleed, { type = "GlobalEffect", effectType = "Debuff" }, { type = "Multiplier", var = "RuptureStack", limit = 3 }) }, ["critical_strikes_that_inflict_bleeding_also_rupture"] = {