From a98178271589b6493384335b75826766fba036a3 Mon Sep 17 00:00:00 2001 From: LocalIdentity Date: Thu, 15 Aug 2024 02:05:47 +1000 Subject: [PATCH] Fix Rage Support not enabling Rage damage bonus The mod was not applying globally so it wasn't working as a buff --- src/Data/SkillStatMap.lua | 2 +- src/Data/Skills/sup_str.lua | 3 --- src/Export/Skills/sup_str.txt | 3 --- 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/Data/SkillStatMap.lua b/src/Data/SkillStatMap.lua index b611bb6036..1b56da62bf 100644 --- a/src/Data/SkillStatMap.lua +++ b/src/Data/SkillStatMap.lua @@ -2060,7 +2060,7 @@ return { flag("SpellCastTimeAddedToCooldownIfTriggered"), }, ["gain_x_rage_on_attack_hit"] = { - flag("Condition:CanGainRage", nil, ModFlag.Attack, 0, { type = "GlobalEffect", effectType = "Buff" }), + flag("Condition:CanGainRage", { type = "GlobalEffect", effectType = "Buff", effectName = "Rage" } ), }, ["warcry_count_power_from_enemies"] = { flag("UsesWarcryPower", { type = "GlobalEffect", effectType = "Buff" }) diff --git a/src/Data/Skills/sup_str.lua b/src/Data/Skills/sup_str.lua index d2809c2add..5984cef1b1 100644 --- a/src/Data/Skills/sup_str.lua +++ b/src/Data/Skills/sup_str.lua @@ -3588,9 +3588,6 @@ skills["SupportRage"] = { ignoreMinionTypes = true, statDescriptionScope = "gem_stat_descriptions", statMap = { - ["support_rage_gain_rage_on_melee_hit_cooldown_ms"] = { - flag("Condition:CanGainRage", { type = "GlobalEffect", effectType = "Buff", effectName = "Rage" } ), - }, ["attack_speed_+%_with_at_least_10_rage"] = { mod("Speed", "INC", nil, ModFlag.Attack, 0, { type = "MultiplierThreshold", var = "Rage", threshold = 10 }) }, diff --git a/src/Export/Skills/sup_str.txt b/src/Export/Skills/sup_str.txt index 6e5e8bf062..5ed470db38 100644 --- a/src/Export/Skills/sup_str.txt +++ b/src/Export/Skills/sup_str.txt @@ -493,9 +493,6 @@ local skills, mod, flag, skill = ... #skill SupportRage statMap = { - ["support_rage_gain_rage_on_melee_hit_cooldown_ms"] = { - flag("Condition:CanGainRage", { type = "GlobalEffect", effectType = "Buff", effectName = "Rage" } ), - }, ["attack_speed_+%_with_at_least_10_rage"] = { mod("Speed", "INC", nil, ModFlag.Attack, 0, { type = "MultiplierThreshold", var = "Rage", threshold = 10 }) },