Navigating to activities using starter pattern

[sidhu18]

- Summary

Move the activity transaction logic to the target activity using the starter pattern. This pattern really helps when we are working in collaborative projects. When a change is made, say a new extra parameter is required for an activity, this wouldn't throw a compile-time error, but our app will crash during runtime.

With this, we can catch during compilation, and project contributors can know the required params for starting the activity.

More information on this pattern: https://blog.mindorks.com/learn-to-write-good-code-in-android-starter-pattern

- Description for the changelog

Instead of starting activities by creating Intent in the calling method, we call a function which is written in the Activity to start the activity.

Existing code:

  val intent = Intent(this, PostDetailsActivity::class.java)
        intent.putExtra(PostDetailsActivity.POST_ID, post.id)

  val options = ActivityOptionsCompat.makeSceneTransitionAnimation(
        this,
        imageView,
        imageView.transitionName
   )

 startActivity(intent, options.toBundle())

Updated:

 val options = ActivityOptionsCompat.makeSceneTransitionAnimation(
       this,
       imageView,
       imageView.transitionName
 )

 PostDetailsActivity.start(this, post.id, options)

- A picture or screenshot regarding change (not mandatory but encouraged)

[PatilShreyas]

@sidhu18 Thanks for this PR 😃. I really liked that approach and thanks for the blog link too. Here are few comments then I'll be happy to merge this.

[PatilShreyas]

This function shouldn't start activity internally using Context of the other Activity. I referred that blog link which you shared. Means we should be confident who's starting the activity. So it would be great if we start the activity from MainActivity itself.

I would suggest to make this method like... 👇🏻

fun getStartIntent(context: Context, postId: Int) = Intent(context, PostDetailsActivity::class.java).apply {
    putExtra(POST_ID, postId)
}

From MainActivity, let's do like... 👇🏻

val intent = PostDetailsActivity.getStartIntent(this, post.id)
startActivity(intent, options.toBundle())

[sidhu18]

That makes sense. Thanks for the quick review and clarification. I will make the necessary changes and push it. 😄

[PatilShreyas]

Thanks, @sidhu18! 😄. LGTM, happy to merge it 🚀. Feel free to contribute again.

[PatilShreyas]

Now looks perfect 💯

[PatilShreyas]

Great! 😃

[PatilShreyas]

@sidhu18 You can also contribute to this repository with same change if sounds good to you: https://github.com/PatilShreyas/NotyKT/

[sidhu18]

@sidhu18 You can also contribute to this repository with same change if sounds good to you: https://github.com/PatilShreyas/NotyKT/

That sounds great, I will definitely look into that. 😀