Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the original website's favicon for tabs that are paused by the Great Suspender #173

Open
Pauan opened this issue Aug 1, 2015 · 4 comments
Assignees

Comments

@Pauan
Copy link
Owner

Pauan commented Aug 1, 2015

Originally reported on Google Code with ID 174

Version of Tab Organizer: 4.3
Version of Google Chrome: 37.0.2062.120 m
Version of operating system: Win 8.1

Please describe the problem you are having, or the feature you want added:

The Great Suspender is the perfect companion app for Tab Organizer. It pauses tabs
so that system resources aren't compromised.  

The one issue is that The Great Suspender's favicon displays for suspended tabs in
Tab Organizer's open tab list instead of the original websites' favicons. It would
be great to show the original favicons.

Reported by steve@organek.com on 2014-09-21 15:23:17

@Pauan
Copy link
Owner Author

Pauan commented Aug 1, 2015

That shouldn't happen, because Tab Organizer uses Chrome APIs to retrieve the favicon.
So either the Chrome APIs are wrong, or The Great Suspender is doing things in a hacky
way that bypasses the Chrome API. I'll take a look into this and see if there's anything
I can do on my end to fix it.

Reported by pcxunlimited on 2014-09-22 09:08:49

  • Status changed: Assigned
  • Labels added: Type-HelpNeeded
  • Labels removed: Type-Unconfirmed

@Pauan Pauan self-assigned this Aug 1, 2015
@Pauan
Copy link
Owner Author

Pauan commented Aug 1, 2015

P.S. Tab Organizer version 5 (which isn't finished yet) will have the ability to unload
tabs. See issue 162 for progress on that.

Reported by pcxunlimited on 2014-09-22 17:06:34

@Pauan
Copy link
Owner Author

Pauan commented Aug 1, 2015

It may be worth mentioning that showing The Great Suspender's favicon for suspended
tabs instead of the original favicon used to be a The Great Suspender issue. You can
see that from the comments in the Extension Store. 

Bypassing the Chrome API may have been the only way for The Great Suspender to fix
that problem. Before posting this issue, I sent an email to you and The Great Suspender's
developer. Hopefully, he can explain how he bypassed the API and you can implement
the bypass in Tab Organizer.

Reported by steve@organek.com on 2014-09-22 17:20:26

@Pauan
Copy link
Owner Author

Pauan commented Aug 1, 2015

Okay, I looked into it some more, and I should be able to fix this, but you'll have
to wait until version 5 is released, which won't be for a while. Thanks for the bug
report.

Reported by pcxunlimited on 2014-11-02 08:12:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant