From 93441f2190dffe4edcc0aaa38d3119a84ac0c02b Mon Sep 17 00:00:00 2001 From: Alexander Neff Date: Fri, 10 May 2024 17:41:09 -0400 Subject: [PATCH] Add screenshot section to PR template --- .github/ISSUE_TEMPLATE/pull_request_template.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/pull_request_template.md b/.github/ISSUE_TEMPLATE/pull_request_template.md index fd4ca01d1..d345ef996 100644 --- a/.github/ISSUE_TEMPLATE/pull_request_template.md +++ b/.github/ISSUE_TEMPLATE/pull_request_template.md @@ -28,6 +28,10 @@ If you are using poetry, you can easily run tests via: `poetry run python tests/e2e_tests.py -t $TARGET -u $USER -p $PASSWORD` There are additional options like `--errors` to display ALL errors (some may not be failures), `--poetry` (output will include the poetry run prepended), `--line-num $START-$END $SINGLE` for only running a subset +## Screenshots (if appropriate): +Screenshots are always nice to have and can give a visual representation of the change. +If appropriate include before and after screenshot(s) to show which results are to be expected. + ## Checklist: - [ ] I have ran Ruff against my changes (via poetry: `poetry run python -m ruff check . --preview`, use `--fix` to automatically fix what it can)