Skip to content

Commit

Permalink
fix PERL_CORE warnings from ExtUtils::CBuilder
Browse files Browse the repository at this point in the history
ExtUtils::CBuilder is used to detect if we have a compiler available.
It has some oddities and doesn't work well in parallel. We run it from a
temporary directory to avoid that. When doing a core build, and in a
temp directory, CBuilder sees PERL_CORE but can't find the perl source
and complains.

If we're running perl core tests, there's no real need to check for a
compiler. We can just assume one is available. Avoid CBuilder's mess and
just return true from our compiler check if running with PERL_CORE.
  • Loading branch information
haarg authored and bingos committed Oct 6, 2020
1 parent 5f03e95 commit 5e55318
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions t/lib/MakeMaker/Test/Utils.pm
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,8 @@ Returns true if there is a compiler available for XS builds.
=cut

sub have_compiler {
return 1 if $ENV{PERL_CORE};

my $have_compiler = 0;

in_dir(sub {
Expand Down

0 comments on commit 5e55318

Please sign in to comment.