Do not serialize ValueFormatter interface member variable #920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deserializing an object from this lib that contains a ValueFormatter member variable, Gson throws an exception. And since there is a ValueFormatter variable in DataSet, and ChartData uses DataSet, this affects many objects. I came across it deserializing my object which contained a PieChart using mGson.fromJson(myJsonString, MyPieChartObject.class);. Making an instance creator as Gson suggested did not solve the problem.
To fix this all I did was make the mValueFormatter transient so it does not get serialized by Gson, and therefore does not throw the exception. It works like a charm, and hopefully shouldn't affect anything negatively.
Before:
(Stack trace)
After:
No exceptions for deserializing any of my objects that contain a chart from this lib anymore!