-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch to use new pipeline trigger by prow in branch 7.5 #3135
feat: switch to use new pipeline trigger by prow in branch 7.5 #3135
Conversation
Based on the pull request title and description, the key changes are that this pull request switches to using a new pipeline trigger by prow in the release-7.5 branch for the Looking at the diff, the changes made are mainly in the Jenkins pipeline configuration files for the One potential problem with this pull request is that there is no explanation provided for why the new pipeline trigger is being used or what benefits it brings. It would be helpful to have more context on why this change is being made and what impact it will have on the CI/CD process. Another potential issue is the change made to Overall, the changes made in this pull request seem to be relatively minor and straightforward. To improve the pull request, it would be helpful to provide more context on why the new pipeline trigger is being used and to clarify the intentions behind the changes to |
Based on the pull request, the change is to switch to a new pipeline trigger by prow in tikv & tiflash branch release-7.5. The diff shows the changes in the blackListTargetBranches for the ghprbBranch. There are no obvious potential problems with this pull request, but it's important to ensure that the new pipeline trigger is fully tested and validated before merging. One suggestion for improvement would be to update the pull request description with more details about the new pipeline trigger and any testing that has been done to validate it. This would provide more context for reviewers and make it easier to assess the impact of the change. |
Based on the PR title and description, the changes seem to be related to switching to a new pipeline trigger for the
Overall, the changes seem reasonable, but the issues identified above should be fixed before merging the PR. |
Key changes:
Potential problems:
Fixing suggestions:
|
/hold |
@purelind: GitHub didn't allow me to request PR reviews from the following users: zhangjinpeng1987. Note that only PingCAP-QE members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@glorv: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Lloyd-Pottiger: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@zanmato1984: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: glorv, Lloyd-Pottiger, wuhuizuo, zanmato1984 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Swtich to use new pipeline trigger by prow in tikv & tiflash branch release-7.5