Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tidb): add ddlv1 unit test pipeline #3150

Merged

Conversation

purelind
Copy link
Collaborator

@purelind purelind commented Sep 30, 2024

This pull request introduces a new Jenkins pipeline job for running unit tests on the latest version of the pingcap/tidb repository. It includes the creation of the pipeline job, its definition, and updates to the relevant presubmits configuration.

New Jenkins Pipeline Job:

Presubmits Configuration:

  • prow-jobs/pingcap/tidb/latest-presubmits.yaml: Added a new presubmit configuration for the pingcap/tidb/pull_unit_test_ddlv1 job, including branches, trigger commands, and context settings.Add a new pipeline foro ddlv1 unit test, we need to monitor the stability of the new pipeline, only support trigger manually currently.

Copy link

ti-chi-bot bot commented Sep 30, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary of changes:

  • A new pipeline for ddlv1 unit test has been added for the pingcap/tidb repository.
  • The pipeline can only be triggered manually.
  • The pull_unit_test_ddlv1.groovy and pod-ghpr_unit_test.yaml files have been added to the repository.
  • A new entry for the pull_unit_test_ddlv1 job has been added to the latest-presubmits.yaml file.

Potential problems:

  • The pipeline can only be triggered manually. It would be better if it could be triggered automatically when there is a change in the codebase.
  • It is unclear what the PROW_JOB_ID parameter is used for. It should be documented or removed if it is not needed.
  • The retry function is used in the Checkout stage without specifying the maximum number of retries. It would be better to set a limit to avoid infinite retries.

Suggestions for fixes:

  • Add an automatic trigger to the pipeline whenever there is a change in the codebase.
  • Document the purpose of the PROW_JOB_ID parameter or remove it if it is not needed.
  • Set a maximum number of retries for the retry function in the Checkout stage.

@ti-chi-bot ti-chi-bot bot added the size/L label Sep 30, 2024
Copy link

ti-chi-bot bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 30, 2024
Copy link

ti-chi-bot bot commented Sep 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-30 06:28:01.350615119 +0000 UTC m=+249836.770828127: ☑️ agreed by wuhuizuo.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 30, 2024
@ti-chi-bot ti-chi-bot bot merged commit 67eb6f5 into PingCAP-QE:main Sep 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants